Bug 180356 - Generate text encoding names and aliases from encodings.json (plus WebKit-specific data)
Summary: Generate text encoding names and aliases from encodings.json (plus WebKit-spe...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 179303
  Show dependency treegraph
 
Reported: 2017-12-04 07:40 PST by Maciej Stachowiak
Modified: 2023-09-21 09:38 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2017-12-04 07:40:06 PST
Generate text encoding names and aliases from encodings.json (plus WebKit-specific data). Doing it this way will remove some grungy macros that define our name tables, and will make it more obvious where we diverge from the Encoding Standard. It might be necessary to fix #19307 first to accomplish this cleanly.
Comment 1 Anne van Kesteren 2022-09-27 06:29:43 PDT
Alex, is this still something we need after the various rounds of cleanup you did?
Comment 2 Anne van Kesteren 2022-09-27 07:37:02 PDT
Per https://github.com/web-platform-tests/wpt/pull/36096 this might still be good. We do acknowledge the x-mac-* encodings, but I don't see EUC-TW mentioned there as being non-compliant or intentional.
Comment 3 Anne van Kesteren 2023-09-21 09:38:01 PDT
Source/WebCore/PAL/pal/text/TextCodecICU.cpp maintains a registry now. It lists some non-standard encodings such as EUC-TW, but that is something to address separately.

The only slight further improvement here would be generating it from encodings.json, but it's not at all clear that is worth the effort given the rate of change.