Bug 180353 - Make ScrollingTreeNode::enclosingFrameNode return the node itself for frame nodes
Summary: Make ScrollingTreeNode::enclosingFrameNode return the node itself for frame n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on: 175135
Blocks: 149264 173833
  Show dependency tree / graph
 
Reported: 2017-12-04 06:13 PST by Frédéric Wang (:fredw)
Modified: 2017-12-06 16:29 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2017-12-04 06:27 PST, Frédéric Wang (:fredw) 		tonikitoo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-12-04 06:13:26 PST 
This function was introduced in bug 175135 to solve an issue with overflow nodes, but it should really include the frame itself when we implement ios frame scrolling.
Comment 1 Frédéric Wang (:fredw) 2017-12-04 06:27:10 PST 
Created attachment 328343 [details]
Patch
Comment 2 Antonio Gomes 2017-12-04 06:54:56 PST 
Comment on attachment 328343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328343&action=review

> Source/WebCore/ChangeLog:8
> +        This function was introduced in bug 175135 to solve a rendering bug with fixed nodes in

fixed nodes -> fixed positioned nodes, for clarity.

> Source/WebCore/ChangeLog:20
> +        (WebCore::ScrollingTreeNode::enclosingFrameNode const): Deleted. Renamed to make explicit

nit: "Deleted" here is confusing. please remove.
Comment 3 Frédéric Wang (:fredw) 2017-12-04 08:46:01 PST 
Committed r225480: <https://trac.webkit.org/changeset/225480>
Comment 4 Radar WebKit Bug Importer 2017-12-06 16:29:33 PST 
<rdar://problem/35896089>