Bug 180339 - WebArchiveResourceWebResourceHandler leaks when pasting
Summary: WebArchiveResourceWebResourceHandler leaks when pasting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-03 15:25 PST by Alexey Proskuryakov
Modified: 2017-12-03 19:34 PST (History)
3 users (show)

See Also:

Attachments
proposed fix (1.37 KB, patch)
2017-12-03 15:28 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-12-03 15:25:46 PST 
Over-retained in WebCore.
Comment 1 Radar WebKit Bug Importer 2017-12-03 15:25:58 PST 
<rdar://problem/35820632>
Comment 2 Alexey Proskuryakov 2017-12-03 15:28:31 PST 
Created attachment 328311 [details]
proposed fix
Comment 3 Joseph Pecoraro 2017-12-03 19:14:31 PST 
So I had a concern about this since the line above said that object was explicitly retained beacuse code later on (in appKit?) would release it. But I didn’t search around for this one. I guess it is safe to say if we see leaks then we should send an auto released.
Comment 4 WebKit Commit Bot 2017-12-03 19:34:48 PST 
Comment on attachment 328311 [details]
proposed fix

Clearing flags on attachment: 328311

Committed r225468: <https://trac.webkit.org/changeset/225468>
Comment 5 WebKit Commit Bot 2017-12-03 19:34:49 PST 
All reviewed patches have been landed.  Closing bug.