RESOLVED FIXED 180336
Re-sync Service Workers web-platform-tests from upstream 
https://bugs.webkit.org/show_bug.cgi?id=180336
Summary Re-sync Service Workers web-platform-tests from upstream
Chris Dumez
Reported 2017-12-03 13:55:39 PST
Re-sync Service Workers web-platform-tests from upstream.
Attachments
Patch (196.13 KB, patch)
2017-12-03 14:12 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (196.09 KB, patch)
2017-12-03 14:25 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (190.52 KB, patch)
2017-12-03 14:52 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (190.60 KB, patch)
2017-12-03 15:09 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.43 MB, application/zip)
2017-12-03 16:19 PST, EWS Watchlist 		no flags
Details
Patch (189.69 KB, patch)
2017-12-03 16:21 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-12-03 14:04:59 PST
Some PRs have not yet landed in WPT. If resincing we need to keep these changes. I’ll ping some wpt people
Chris Dumez
Comment 2 2017-12-03 14:12:30 PST
Created attachment 328305 [details] Patch
Chris Dumez
Comment 3 2017-12-03 14:15:30 PST
(In reply to youenn fablet from comment #1) > Some PRs have not yet landed in WPT. If resincing we need to keep these > changes. > I’ll ping some wpt people I did keep sone changes related to ww1. Anything else you see is missing?
Chris Dumez
Comment 4 2017-12-03 14:25:38 PST
Created attachment 328307 [details] Patch
Chris Dumez
Comment 5 2017-12-03 14:28:37 PST
Comment on attachment 328307 [details] Patch Will keep changes from https://github.com/w3c/web-platform-tests/pull/8507 too.
Chris Dumez
Comment 6 2017-12-03 14:31:15 PST
(In reply to Chris Dumez from comment #5) > Comment on attachment 328307 [details] > Patch > > Will keep changes from https://github.com/w3c/web-platform-tests/pull/8507 > too. and https://github.com/w3c/web-platform-tests/pull/8289. https://github.com/w3c/web-platform-tests/pull/8037 was already kept. I think this is all. Will reupload shortly.
Chris Dumez
Comment 7 2017-12-03 14:52:42 PST
Created attachment 328308 [details] Patch
Chris Dumez
Comment 8 2017-12-03 14:53:14 PST
Ok, please double check but I believe I kept all local changes.
Chris Dumez
Comment 9 2017-12-03 15:09:14 PST
Created attachment 328310 [details] Patch
Darin Adler
Comment 10 2017-12-03 15:15:18 PST
I was going to do a rs=me, but was waiting to see the EWS results.
EWS Watchlist
Comment 11 2017-12-03 16:19:13 PST
Comment on attachment 328310 [details] Patch Attachment 328310 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5480050 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html
EWS Watchlist
Comment 12 2017-12-03 16:19:14 PST
Created attachment 328312 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Chris Dumez
Comment 13 2017-12-03 16:21:55 PST
Created attachment 328313 [details] Patch
Chris Dumez
Comment 14 2017-12-03 17:00:17 PST
EWS is green.
WebKit Commit Bot
Comment 15 2017-12-03 18:15:13 PST
Comment on attachment 328313 [details] Patch Clearing flags on attachment: 328313 Committed r225467: <https://trac.webkit.org/changeset/225467>
WebKit Commit Bot
Comment 16 2017-12-03 18:15:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 17 2017-12-03 18:16:20 PST
<rdar://problem/35821482>
youenn fablet
Comment 18 2017-12-03 21:00:15 PST
(In reply to Chris Dumez from comment #6) > (In reply to Chris Dumez from comment #5) > > Comment on attachment 328307 [details] > > Patch > > > > Will keep changes from https://github.com/w3c/web-platform-tests/pull/8507 > > too. > > and https://github.com/w3c/web-platform-tests/pull/8289. > > https://github.com/w3c/web-platform-tests/pull/8037 was already kept. > > I think this is all. Will reupload shortly. Patch seems fine to me: test-helpers.sub.js does not have any cors modification and I do not see any clientId === "" modifications.
Note You need to log in before you can comment on or make changes to this bug.