Bug 180336 - Re-sync Service Workers web-platform-tests from upstream
Summary: Re-sync Service Workers web-platform-tests from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-03 13:55 PST by Chris Dumez
Modified: 2017-12-03 21:00 PST (History)
9 users (show)

See Also:


Attachments
Patch (196.13 KB, patch)
2017-12-03 14:12 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (196.09 KB, patch)
2017-12-03 14:25 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (190.52 KB, patch)
2017-12-03 14:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (190.60 KB, patch)
2017-12-03 15:09 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.43 MB, application/zip)
2017-12-03 16:19 PST, EWS Watchlist
no flags Details
Patch (189.69 KB, patch)
2017-12-03 16:21 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-12-03 13:55:39 PST
Re-sync Service Workers web-platform-tests from upstream.
Comment 1 youenn fablet 2017-12-03 14:04:59 PST
Some PRs have not yet landed in WPT. If resincing we need to keep these changes.
I’ll ping some wpt people
Comment 2 Chris Dumez 2017-12-03 14:12:30 PST
Created attachment 328305 [details]
Patch
Comment 3 Chris Dumez 2017-12-03 14:15:30 PST
(In reply to youenn fablet from comment #1)
> Some PRs have not yet landed in WPT. If resincing we need to keep these
> changes.
> I’ll ping some wpt people

I did keep sone changes related to ww1. Anything else you see is missing?
Comment 4 Chris Dumez 2017-12-03 14:25:38 PST
Created attachment 328307 [details]
Patch
Comment 5 Chris Dumez 2017-12-03 14:28:37 PST
Comment on attachment 328307 [details]
Patch

Will keep changes from https://github.com/w3c/web-platform-tests/pull/8507 too.
Comment 6 Chris Dumez 2017-12-03 14:31:15 PST
(In reply to Chris Dumez from comment #5)
> Comment on attachment 328307 [details]
> Patch
> 
> Will keep changes from https://github.com/w3c/web-platform-tests/pull/8507
> too.

and https://github.com/w3c/web-platform-tests/pull/8289.

https://github.com/w3c/web-platform-tests/pull/8037 was already kept.

I think this is all. Will reupload shortly.
Comment 7 Chris Dumez 2017-12-03 14:52:42 PST
Created attachment 328308 [details]
Patch
Comment 8 Chris Dumez 2017-12-03 14:53:14 PST
Ok, please double check but I believe I kept all local changes.
Comment 9 Chris Dumez 2017-12-03 15:09:14 PST
Created attachment 328310 [details]
Patch
Comment 10 Darin Adler 2017-12-03 15:15:18 PST
I was going to do a rs=me, but was waiting to see the EWS results.
Comment 11 EWS Watchlist 2017-12-03 16:19:13 PST
Comment on attachment 328310 [details]
Patch

Attachment 328310 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5480050

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https.html
Comment 12 EWS Watchlist 2017-12-03 16:19:14 PST
Created attachment 328312 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 13 Chris Dumez 2017-12-03 16:21:55 PST
Created attachment 328313 [details]
Patch
Comment 14 Chris Dumez 2017-12-03 17:00:17 PST
EWS is green.
Comment 15 WebKit Commit Bot 2017-12-03 18:15:13 PST
Comment on attachment 328313 [details]
Patch

Clearing flags on attachment: 328313

Committed r225467: <https://trac.webkit.org/changeset/225467>
Comment 16 WebKit Commit Bot 2017-12-03 18:15:14 PST
All reviewed patches have been landed.  Closing bug.
Comment 17 Radar WebKit Bug Importer 2017-12-03 18:16:20 PST
<rdar://problem/35821482>
Comment 18 youenn fablet 2017-12-03 21:00:15 PST
(In reply to Chris Dumez from comment #6)
> (In reply to Chris Dumez from comment #5)
> > Comment on attachment 328307 [details]
> > Patch
> > 
> > Will keep changes from https://github.com/w3c/web-platform-tests/pull/8507
> > too.
> 
> and https://github.com/w3c/web-platform-tests/pull/8289.
> 
> https://github.com/w3c/web-platform-tests/pull/8037 was already kept.
> 
> I think this is all. Will reupload shortly.

Patch seems fine to me: test-helpers.sub.js does not have any cors modification and I do not see any clientId === "" modifications.