Bug 180335 - Rename DestroyFunc to avoid redefinition on unified build
Summary: Rename DestroyFunc to avoid redefinition on unified build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-03 08:56 PST by Caio Lima
Modified: 2017-12-03 15:01 PST (History)
9 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2017-12-03 09:26 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (8.40 KB, patch)
2017-12-03 13:56 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Patch (8.40 KB, patch)
2017-12-03 14:10 PST, Caio Lima 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2017-12-03 08:56:03 PST 
...
Comment 1 Caio Lima 2017-12-03 09:26:48 PST 
Created attachment 328296 [details]
Patch
Comment 2 Filip Pizlo 2017-12-03 12:18:25 PST 
Comment on attachment 328296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328296&action=review

R=me. I recommend also removing the anonymous namespaces that wrap these in this patch.

> Source/JavaScriptCore/heap/HeapCellType.cpp:40
> +struct HeapDestroyFunc {

Maybe call this one: DefaultDestroyFunc.
Comment 3 Caio Lima 2017-12-03 13:56:09 PST 
Created attachment 328303 [details]
Patch
Comment 4 Caio Lima 2017-12-03 13:57:07 PST 
Comment on attachment 328303 [details]
Patch

Applied changes
Comment 5 WebKit Commit Bot 2017-12-03 13:58:07 PST 
Comment on attachment 328303 [details]
Patch

Rejecting attachment 328303 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 328303, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/5478869
Comment 6 Caio Lima 2017-12-03 14:10:52 PST 
Created attachment 328304 [details]
Patch
Comment 7 Caio Lima 2017-12-03 14:12:30 PST 
Thanks for the review!
Comment 8 WebKit Commit Bot 2017-12-03 15:00:50 PST 
Comment on attachment 328304 [details]
Patch

Clearing flags on attachment: 328304

Committed r225464: <https://trac.webkit.org/changeset/225464>
Comment 9 WebKit Commit Bot 2017-12-03 15:00:52 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-12-03 15:01:23 PST 
<rdar://problem/35820544>