Bug 180314 - [GStreamer] GstPad leaked in WebKitTextCombiner
Summary: [GStreamer] GstPad leaked in WebKitTextCombiner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2017-12-02 11:07 PST by Carlos Garcia Campos
Modified: 2017-12-03 01:10 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2017-12-02 11:09 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-12-02 11:07:21 PST
gst_element_get_static_pad() returns a full reference that si never freed, because gst_ghost_pad_new doesn't take the ownership of the given pad.

==1306== 68,856 (33,792 direct, 35,064 indirect) bytes in 64 blocks are definitely lost in loss record 20,295 of 20,320
==1306==    at 0xF7AF03C: g_type_create_instance (gtype.c:1845)
==1306==    by 0xF78FAF7: g_object_new_internal (gobject.c:1797)
==1306==    by 0xF79184F: g_object_new_valist (gobject.c:2120)
==1306==    by 0xF791BAB: g_object_new (gobject.c:1640)
==1306==    by 0xD3D36E0: gst_pad_new_from_template (gstpad.c:868)
==1306==    by 0xD3D373B: gst_pad_new_from_static_template (gstpad.c:893)
==1306==    by 0x262E4FAB: gst_funnel_init (gstfunnel.c:213)
==1306==    by 0xF7AEF72: g_type_create_instance (gtype.c:1866)
==1306==    by 0xF78FAF7: g_object_new_internal (gobject.c:1797)
==1306==    by 0xF7911B4: g_object_new_with_properties (gobject.c:1965)
==1306==    by 0xF791BC0: g_object_new (gobject.c:1637)
==1306==    by 0xD3B9CA5: gst_element_factory_create (gstelementfactory.c:372)
Comment 1 Carlos Garcia Campos 2017-12-02 11:09:27 PST
Created attachment 328242 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-12-03 01:08:52 PST
Committed r225459: <https://trac.webkit.org/changeset/225459>
Comment 3 Radar WebKit Bug Importer 2017-12-03 01:10:05 PST
<rdar://problem/35817669>