Bug 180295 - Add a log channel for viewports
Summary: Add a log channel for viewports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-01 16:33 PST by Simon Fraser (smfr)
Modified: 2017-12-04 09:49 PST (History)
11 users (show)

See Also:

Attachments
Patch (22.28 KB, patch)
2017-12-01 16:33 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (25.89 KB, patch)
2017-12-01 17:42 PST, Simon Fraser (smfr) 		zalan: review+
zalan: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-12-01 16:33:19 PST 
Need a log channel that shows viewport size computations
Comment 1 Simon Fraser (smfr) 2017-12-01 16:33:37 PST 
Created attachment 328184 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-12-01 17:42:01 PST 
Created attachment 328193 [details]
Patch
Comment 3 zalan 2017-12-01 18:33:00 PST 
Comment on attachment 328193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328193&action=review

> Source/WebCore/loader/FrameLoader.cpp:1143
> +//    if (m_frame.view()) {
> +        LOG(Scrolling, "FrameLoader::completed() clearing maintainScrollPosition anchor");
> +//        m_frame.view()->maintainScrollPositionAtAnchor(nullptr);
> +//    }

???
Comment 4 Simon Fraser (smfr) 2017-12-04 09:47:06 PST 
https://trac.webkit.org/changeset/225449/webkit
Comment 5 Radar WebKit Bug Importer 2017-12-04 09:49:12 PST 
<rdar://problem/35831339>