Bug 180293 - download-latest-github-release.py should use existing release ANY time latest is not found
Summary: download-latest-github-release.py should use existing release ANY time latest...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-01 16:15 PST by Ross Kirsling
Modified: 2017-12-04 15:06 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2017-12-01 16:23 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2017-12-01 16:15:59 PST 
download-latest-github-release.py should use existing release ANY time latest is not found
Comment 1 Ross Kirsling 2017-12-01 16:23:43 PST 
Created attachment 328183 [details]
Patch
Comment 2 Per Arne Vollan 2017-12-04 14:38:54 PST 
Comment on attachment 328183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328183&action=review

R=me.

> Tools/Scripts/download-latest-github-release.py:117
> +    release_url, latest_version_info = find_latest_release(args)

Could 'find_latest_release' still throw an exception? If so, we might want to catch that.
Comment 3 Ross Kirsling 2017-12-04 14:51:52 PST 
(In reply to Per Arne Vollan from comment #2)
> > Tools/Scripts/download-latest-github-release.py:117
> > +    release_url, latest_version_info = find_latest_release(args)
> 
> Could 'find_latest_release' still throw an exception? If so, we might want
> to catch that.

A few days ago, Basuke added an outer `try` because find_latest_release was catching just HTTPError instead of the more general URLError (which includes network errors and the like). This patch changes find_latest_release to catch URLError so that the outer `try` is unnecessary. It could still hit a TypeError when decoding the JSON response, but we probably want user intervention in such a strange case anyway.
Comment 4 WebKit Commit Bot 2017-12-04 15:05:03 PST 
Comment on attachment 328183 [details]
Patch

Clearing flags on attachment: 328183

Committed r225498: <https://trac.webkit.org/changeset/225498>
Comment 5 WebKit Commit Bot 2017-12-04 15:05:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-04 15:06:14 PST 
<rdar://problem/35840632>