download-latest-github-release.py should use existing release ANY time latest is not found
Created attachment 328183 [details] Patch
Comment on attachment 328183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328183&action=review R=me. > Tools/Scripts/download-latest-github-release.py:117 > + release_url, latest_version_info = find_latest_release(args) Could 'find_latest_release' still throw an exception? If so, we might want to catch that.
(In reply to Per Arne Vollan from comment #2) > > Tools/Scripts/download-latest-github-release.py:117 > > + release_url, latest_version_info = find_latest_release(args) > > Could 'find_latest_release' still throw an exception? If so, we might want > to catch that. A few days ago, Basuke added an outer `try` because find_latest_release was catching just HTTPError instead of the more general URLError (which includes network errors and the like). This patch changes find_latest_release to catch URLError so that the outer `try` is unnecessary. It could still hit a TypeError when decoding the JSON response, but we probably want user intervention in such a strange case anyway.
Comment on attachment 328183 [details] Patch Clearing flags on attachment: 328183 Committed r225498: <https://trac.webkit.org/changeset/225498>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35840632>