WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
180291
Let's scramble ClassInfo pointers in cells.
https://bugs.webkit.org/show_bug.cgi?id=180291
Summary
Let's scramble ClassInfo pointers in cells.
Mark Lam
Reported
2017-12-01 15:32:24 PST
patch coming.
Attachments
proposed patch.
(27.35 KB, patch)
2017-12-01 15:40 PST
,
Mark Lam
jfbastien
: review+
Details
Formatted Diff
Diff
patch for landing + speculative build fix
(29.03 KB, patch)
2017-12-01 16:17 PST
,
Mark Lam
no flags
Details
Formatted Diff
Diff
x86_64 benchmark result.
(8.66 KB, text/plain)
2017-12-01 16:48 PST
,
Mark Lam
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-12-01 15:32:59 PST
<
rdar://problem/35807620
>
Mark Lam
Comment 2
2017-12-01 15:40:02 PST
Created
attachment 328170
[details]
proposed patch.
EWS Watchlist
Comment 3
2017-12-01 15:42:29 PST
Attachment 328170
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:31: g_classInfoScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:32: g_masmScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
JF Bastien
Comment 4
2017-12-01 15:49:46 PST
Comment on
attachment 328170
[details]
proposed patch. r=me
Mark Lam
Comment 5
2017-12-01 16:17:20 PST
Created
attachment 328180
[details]
patch for landing + speculative build fix
EWS Watchlist
Comment 6
2017-12-01 16:19:30 PST
Attachment 328180
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:31: g_classInfoScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp:32: g_masmScrambledPtrKey is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 7
2017-12-01 16:48:28 PST
Created
attachment 328186
[details]
x86_64 benchmark result. Perf appears to be neutral.
Mark Lam
Comment 8
2017-12-01 17:13:46 PST
Thanks for the review. Landed in
r225437
: <
http://trac.webkit.org/r225437
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug