Bug 180278 - [build.webkit.org] Move python code to load config from master.cfg in separate file
Summary: [build.webkit.org] Move python code to load config from master.cfg in separat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-01 13:52 PST by Aakash Jain
Modified: 2017-12-01 16:40 PST (History)
8 users (show)

See Also:

Attachments
Proposed patch (12.26 KB, patch)
2017-12-01 13:57 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-12-01 13:52:59 PST 
master.cfg is a configuration file. It should contain only the configuration. All the logic (python code) should be in corresponding python files. Currently it contains lot of python code to load and parse config file. It should be moved to a separate python file.
Comment 1 Aakash Jain 2017-12-01 13:57:03 PST 
Created attachment 328152 [details]
Proposed patch
Comment 2 EWS Watchlist 2017-12-01 14:00:31 PST 
Attachment 328152 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:76:  whitespace before ')'  [pep8/E202] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py:88:  deprecated form of raising exception  [pep8/W602] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-12-01 16:39:36 PST 
Comment on attachment 328152 [details]
Proposed patch

Clearing flags on attachment: 328152

Committed r225433: <https://trac.webkit.org/changeset/225433>
Comment 4 WebKit Commit Bot 2017-12-01 16:39:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-01 16:40:30 PST 
<rdar://problem/35809148>