Bug 180273 - WebAssembly: stack trace improvement follow-ups
Summary: WebAssembly: stack trace improvement follow-ups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords: InRadar
Depends on: 179343
Blocks:
  Show dependency treegraph
 
Reported: 2017-12-01 13:08 PST by JF Bastien
Modified: 2017-12-01 14:21 PST (History)
10 users (show)

See Also:


Attachments
patch (4.46 KB, patch)
2017-12-01 13:09 PST, JF Bastien
sbarati: review+
sbarati: commit-queue-
Details | Formatted Diff | Diff
patch (4.52 KB, patch)
2017-12-01 13:45 PST, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-12-01 13:08:10 PST
Follow-up on comments after #179343 got committed.
Comment 1 JF Bastien 2017-12-01 13:09:55 PST
Created attachment 328142 [details]
patch
Comment 2 Saam Barati 2017-12-01 13:34:22 PST
Comment on attachment 328142 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328142&action=review

> Source/JavaScriptCore/wasm/WasmNameSection.h:53
> +    WTF_MAKE_NONCOPYABLE(NameSection);

We usually put this at the very top of classes/structs.
Comment 3 JF Bastien 2017-12-01 13:45:44 PST
Created attachment 328150 [details]
patch
Comment 4 WebKit Commit Bot 2017-12-01 14:19:08 PST
Comment on attachment 328150 [details]
patch

Clearing flags on attachment: 328150

Committed r225416: <https://trac.webkit.org/changeset/225416>
Comment 5 WebKit Commit Bot 2017-12-01 14:19:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-12-01 14:21:07 PST
<rdar://problem/35805673>