WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
180262
[Gstreamer][MSE] Add string representation for GStreamerMediaSample
https://bugs.webkit.org/show_bug.cgi?id=180262
Summary
[Gstreamer][MSE] Add string representation for GStreamerMediaSample
Alicia Boya García
Reported
2017-12-01 10:23:47 PST
GStreamerMediaSample::dump() represents the sample as an empty string, which is not helpful for debugging. This method is supposed to write useful information about the sample like PTS, DTS, duration... The set of properties to write is platform-dependent.
Attachments
Patch
(2.57 KB, patch)
2017-12-01 10:25 PST
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
Patch
(2.56 KB, patch)
2017-12-01 12:31 PST
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
Patch
(18.91 KB, patch)
2017-12-01 16:06 PST
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
Patch
(2.56 KB, patch)
2017-12-01 16:10 PST
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
Patch
(3.10 KB, patch)
2018-02-12 12:04 PST
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2017-12-01 10:25:56 PST
Created
attachment 328116
[details]
Patch
EWS Watchlist
Comment 2
2017-12-01 10:31:47 PST
Attachment 328116
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:120: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alicia Boya García
Comment 3
2017-12-01 12:31:25 PST
Created
attachment 328131
[details]
Patch
Alicia Boya García
Comment 4
2017-12-01 16:06:41 PST
Created
attachment 328175
[details]
Patch
Alicia Boya García
Comment 5
2017-12-01 16:09:58 PST
webkit-patch upload -g <hash> has uploaded the wrong patch...
Alicia Boya García
Comment 6
2017-12-01 16:10:47 PST
Created
attachment 328177
[details]
Patch
Xabier Rodríguez Calvar
Comment 7
2017-12-05 00:24:46 PST
Comment on
attachment 328177
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=328177&action=review
Patch is not wrong, though I'd improve it.
> Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:120 > + out.print("{PTS(", presentationTime(), "), DTS(", decodeTime(), "), duration(", duration(), "), flags(", (int)flags(),
Instead of (int), I'd use a C++ cast, though in this case I'd rather dump the flags instead of just casting them to an int.
Alicia Boya García
Comment 8
2018-02-12 12:04:10 PST
Created
attachment 333613
[details]
Patch
WebKit Commit Bot
Comment 9
2018-02-13 04:11:38 PST
Comment on
attachment 333613
[details]
Patch Clearing flags on attachment: 333613 Committed
r228418
: <
https://trac.webkit.org/changeset/228418
>
WebKit Commit Bot
Comment 10
2018-02-13 04:11:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11
2018-02-13 04:12:27 PST
<
rdar://problem/37493448
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug