GStreamerMediaSample::dump() represents the sample as an empty string, which is not helpful for debugging. This method is supposed to write useful information about the sample like PTS, DTS, duration... The set of properties to write is platform-dependent.
Created attachment 328116 [details] Patch
Attachment 328116 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:120: Missing space after , [whitespace/comma] [3] ERROR: Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:121: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 328131 [details] Patch
Created attachment 328175 [details] Patch
webkit-patch upload -g <hash> has uploaded the wrong patch...
Created attachment 328177 [details] Patch
Comment on attachment 328177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328177&action=review Patch is not wrong, though I'd improve it. > Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:120 > + out.print("{PTS(", presentationTime(), "), DTS(", decodeTime(), "), duration(", duration(), "), flags(", (int)flags(), Instead of (int), I'd use a C++ cast, though in this case I'd rather dump the flags instead of just casting them to an int.
Created attachment 333613 [details] Patch
Comment on attachment 333613 [details] Patch Clearing flags on attachment: 333613 Committed r228418: <https://trac.webkit.org/changeset/228418>
All reviewed patches have been landed. Closing bug.
<rdar://problem/37493448>