Bug 180247 - Cursor is not visible after exiting full screen video
Summary: Cursor is not visible after exiting full screen video
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-01 07:38 PST by Antoine Quint
Modified: 2017-12-30 13:37 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.20 KB, patch)
2017-12-01 07:47 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-elcapitan (2.14 MB, application/zip)
2017-12-01 08:43 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (2.54 MB, application/zip)
2017-12-01 08:55 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (2.89 MB, application/zip)
2017-12-01 09:06 PST, EWS Watchlist
no flags Details
Patch (6.06 KB, patch)
2017-12-04 05:12 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-12-01 07:38:13 PST
When playing a video in fullscreen and letting the mouse cursor be idle for 3 seconds, the cursor disappears. However, if you press Esc. to exit fullscreen, the cursor remains hidden and moving the mouse still has the cursor hidden. Only mousing out of the browser window brings the cursor back.
Comment 1 Antoine Quint 2017-12-01 07:38:26 PST
<rdar://problem/33885922>
Comment 2 Antoine Quint 2017-12-01 07:47:47 PST
Created attachment 328090 [details]
Patch
Comment 3 Antoine Quint 2017-12-01 08:33:52 PST
This bug seems to have been introduced in https://bugs.webkit.org/show_bug.cgi?id=107601.
Comment 4 EWS Watchlist 2017-12-01 08:43:34 PST
Comment on attachment 328090 [details]
Patch

Attachment 328090 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5446382

New failing tests:
fullscreen/video-cursor-auto-hide.html
Comment 5 EWS Watchlist 2017-12-01 08:43:36 PST
Created attachment 328093 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 EWS Watchlist 2017-12-01 08:55:17 PST
Comment on attachment 328090 [details]
Patch

Attachment 328090 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5446479

New failing tests:
fullscreen/video-cursor-auto-hide.html
Comment 7 EWS Watchlist 2017-12-01 08:55:18 PST
Created attachment 328096 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 EWS Watchlist 2017-12-01 09:06:40 PST
Comment on attachment 328090 [details]
Patch

Attachment 328090 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5446523

New failing tests:
fullscreen/video-cursor-auto-hide.html
Comment 9 EWS Watchlist 2017-12-01 09:06:41 PST
Created attachment 328097 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Antoine Quint 2017-12-04 05:12:16 PST
Created attachment 328342 [details]
Patch
Comment 11 Dean Jackson 2017-12-04 14:13:50 PST
Comment on attachment 328342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328342&action=review

> Source/WebCore/ChangeLog:16
> +        No test provided as I don't believe this platform behavior can be tested, there is no API to query
> +        whether the cursor is visible.

There must be!
Comment 12 Antoine Quint 2017-12-04 14:25:14 PST
(In reply to Dean Jackson from comment #11)
> Comment on attachment 328342 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328342&action=review
> 
> > Source/WebCore/ChangeLog:16
> > +        No test provided as I don't believe this platform behavior can be tested, there is no API to query
> > +        whether the cursor is visible.
> 
> There must be!

There was CGCursorIsVisible but it's been deprecated without a known replacement and is now non-functional.
Comment 13 WebKit Commit Bot 2017-12-04 14:47:07 PST
Comment on attachment 328342 [details]
Patch

Clearing flags on attachment: 328342

Committed r225494: <https://trac.webkit.org/changeset/225494>
Comment 14 WebKit Commit Bot 2017-12-04 14:47:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 15 mitz 2017-12-30 13:37:52 PST
(In reply to WebKit Commit Bot from comment #13)
> Comment on attachment 328342 [details]
> Patch
> 
> Clearing flags on attachment: 328342
> 
> Committed r225494: <https://trac.webkit.org/changeset/225494>

This caused bug 181193.