RESOLVED FIXED 18024
[PATCH] Misnamed method preventing the method overriding 
https://bugs.webkit.org/show_bug.cgi?id=18024
Summary [PATCH] Misnamed method preventing the method overriding
Vincent Ricard
Reported 2008-03-23 10:39:37 PDT
RenderCounter inherits from RenderObject; while RenderObject declares a 'isCounter' method, RenderCounter declares a 'isRenderCounter' method. One of these methods should be renamed to have the correct behavior (method overriding to declare a RenderObject as a RenderCounter).
Attachments
rename the declared method in RenderCounter (964 bytes, patch)
2008-03-23 10:40 PDT, Vincent Ricard 		no flags
DetailsFormatted DiffDiff
rename the declared method in RenderCounter + ChangeLog (1.54 KB, patch)
2008-03-23 11:00 PDT, Vincent Ricard 		aroben: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vincent Ricard
Comment 1 2008-03-23 10:40:31 PDT
Created attachment 19982 [details] rename the declared method in RenderCounter
Vincent Ricard
Comment 2 2008-03-23 10:43:12 PDT
Comment on attachment 19982 [details] rename the declared method in RenderCounter sorry... wrong review flag
mitz
Comment 3 2008-03-23 10:50:08 PDT
Comment on attachment 19982 [details] rename the declared method in RenderCounter Please add a layout test and a change log.
Vincent Ricard
Comment 4 2008-03-23 11:00:58 PDT
Created attachment 19983 [details] rename the declared method in RenderCounter + ChangeLog I dont know how to create a layout test, since this method is only called by CounterNode (which is only used by RenderCounter...)
Mark Rowe (bdash)
Comment 5 2008-03-23 18:20:47 PDT
One idea for creating a regression test that Mitz mentioned to me on IRC is to introduce an assertion at the single point where isCounter is called such that it will fail when this change makes a difference (eg, when the renderer is a RenderCounter instance. From there it should be possible to determine how to create a regression test.
Adam Roben (:aroben)
Comment 6 2008-04-02 08:27:58 PDT
Comment on attachment 19983 [details] rename the declared method in RenderCounter + ChangeLog The patch looks fine, but please create a regression test as requested by Mitz and Mark. You can find some information on our regression tests here: <http://webkit.org/quality/testing.html>. The tests all reside in the LayoutTests directory, and any new test placed in that directory will be automatically found and run by the run-webkit-tests script.
Alexey Proskuryakov
Comment 7 2010-06-11 17:30:33 PDT
This was fixed in <http://trac.webkit.org/changeset/35667>.
Note You need to log in before you can comment on or make changes to this bug.