RESOLVED FIXED 180238
[FTL] Optimize ObjectAllocationSinking mergePointerSets by using removeIf 
https://bugs.webkit.org/show_bug.cgi?id=180238
Summary [FTL] Optimize ObjectAllocationSinking mergePointerSets by using removeIf
Yusuke Suzuki
Reported 2017-11-30 23:51:19 PST
[FTL] Optimize ObjectAllocationSinking mergePointerSets by using removeIf
Attachments
Patch (4.95 KB, patch)
2017-11-30 23:53 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-11-30 23:53:59 PST
Created attachment 328074 [details] Patch
Saam Barati
Comment 2 2018-01-03 18:08:29 PST
Comment on attachment 328074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328074&action=review > Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:620 > + if (my.contains(entry.key)) > + continue; > + escape(entry.value); I know you copied this from below, but I think this is better as: if (!my.contains(entry.key)) escape(entry.value);
Yusuke Suzuki
Comment 3 2018-01-04 07:43:58 PST
Comment on attachment 328074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328074&action=review >> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:620 >> + escape(entry.value); > > I know you copied this from below, but I think this is better as: > if (!my.contains(entry.key)) > escape(entry.value); OK, fixed.
Yusuke Suzuki
Comment 4 2018-01-04 07:51:56 PST
Committed r226406: <https://trac.webkit.org/changeset/226406>
Radar WebKit Bug Importer
Comment 5 2018-01-04 07:52:22 PST
<rdar://problem/36297454>
Note You need to log in before you can comment on or make changes to this bug.