Bug 180221 - Fix some NSOperationQueue leaks
Summary: Fix some NSOperationQueue leaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 15:30 PST by Joseph Pecoraro
Modified: 2017-11-30 16:20 PST (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.04 KB, patch)
2017-11-30 15:31 PST, Joseph Pecoraro 		thorton: review+
thorton: commit-queue+
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (3.01 KB, patch)
2017-11-30 15:33 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-11-30 15:30:57 PST 
Fix some NSOperationQueue leaks

There are some instances of [NSOperationQueue new] that aren't being released. These will be leaks.

Caught by searching for general uses of " new]" in Source.
Comment 1 Joseph Pecoraro 2017-11-30 15:31:44 PST 
Created attachment 328041 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2017-11-30 15:32:55 PST 
Err not Web Inspector... Let me fix ChangeLog.
Comment 3 Joseph Pecoraro 2017-11-30 15:33:50 PST 
Created attachment 328042 [details]
[PATCH] Proposed Fix
Comment 4 Wenson Hsieh 2017-11-30 15:47:38 PST 
Comment on attachment 328042 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=328042&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3726
> +            RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]);

Nit - auto here?

> Source/WebKitLegacy/mac/WebView/WebView.mm:6732
> +            RetainPtr<NSOperationQueue> queue = adoptNS([NSOperationQueue new]);

Ditto.
Comment 5 WebKit Commit Bot 2017-11-30 16:18:11 PST 
Comment on attachment 328042 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 328042

Committed r225369: <https://trac.webkit.org/changeset/225369>
Comment 6 WebKit Commit Bot 2017-11-30 16:18:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-30 16:20:54 PST 
<rdar://problem/35785793>