Bug 180220 - WKURLSchemeHandler.request should include HTTPBody
Summary: WKURLSchemeHandler.request should include HTTPBody
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 14:46 PST by Alex Christensen
Modified: 2018-10-10 12:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (21.30 KB, patch)
2017-11-30 14:48 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (21.77 KB, patch)
2017-11-30 15:00 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-11-30 14:46:31 PST 
WKURLSchemeHandler.request should include HTTPBody
Comment 1 Alex Christensen 2017-11-30 14:48:31 PST 
Created attachment 328034 [details]
Patch
Comment 2 Alex Christensen 2017-11-30 14:52:51 PST 
Comment on attachment 328034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328034&action=review

> Source/WebKit/Shared/URLSchemeTaskParameters.cpp:42
> +    if (request.httpBody()) {
> +        encoder << true;
> +        request.httpBody()->encode(encoder);

This is similar to NetworkResourceLoadParameters::encode except we are encoding to the UIProcess, so we don't need to encode sandbox extensions like we do there.
Comment 3 Alex Christensen 2017-11-30 15:00:46 PST 
Created attachment 328036 [details]
Patch
Comment 4 Alex Christensen 2017-11-30 15:16:43 PST 
http://trac.webkit.org/r225358
Comment 5 Radar WebKit Bug Importer 2017-11-30 15:18:42 PST 
<rdar://problem/35784105>
Comment 6 Chet Corcos 2018-10-10 12:59:43 PDT 
Hey there, how do I know if / when this makes it into an iOS release?