Bug 180218 - Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS
Summary: Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 11
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 14:27 PST by Daniel Bates
Modified: 2017-11-30 16:51 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.59 KB, patch)
2017-11-30 14:30 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (10.30 KB, patch)
2017-11-30 15:30 PST, Daniel Bates 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-11-30 14:27:53 PST 
Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS.
Comment 1 Radar WebKit Bug Importer 2017-11-30 14:28:40 PST 
<rdar://problem/35782555>
Comment 2 Daniel Bates 2017-11-30 14:30:00 PST 
Created attachment 328029 [details]
Patch
Comment 3 Daniel Bates 2017-11-30 15:30:02 PST 
Created attachment 328040 [details]
Patch
Comment 4 Alex Christensen 2017-11-30 15:34:58 PST 
Comment on attachment 328040 [details]
Patch

We should make API tests work on both platforms, too.
Comment 5 Daniel Bates 2017-11-30 15:59:37 PST 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 328040 [details]
> Patch
> 
> We should make API tests work on both platforms, too.

Do you mind if I make this test run on iOS in a follow up bug? The test makes use of TestWKWebView’s mouseUpAtPoint() to click the alternative presentation button. And this function is only implemented on Mac. We either need to implement the function for iOS or we need to update the existing unit test to trigger the button using another mechanism.
Comment 6 Daniel Bates 2017-11-30 16:48:23 PST 
(In reply to Daniel Bates from comment #5)
> (In reply to Alex Christensen from comment #4)
> > Comment on attachment 328040 [details]
> > Patch
> > 
> > We should make API tests work on both platforms, too.
> 
> Do you mind if I make this test run on iOS in a follow up bug? The test
> makes use of TestWKWebView’s mouseUpAtPoint() to click the alternative
> presentation button. And this function is only implemented on Mac. We either
> need to implement the function for iOS 

Teaching TestWKWebView to simulate a mouse click/tap on iOS would be more beneficial to the project. We have an existing bug to cover this, bug #172614.
Comment 7 Daniel Bates 2017-11-30 16:51:23 PST 
Committed r225372: <https://trac.webkit.org/changeset/225372>