Bug 180215 – Support serviceWorkerRegistration.update() inside service workers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Support serviceWorkerRegistration.update() inside service workers.

[Chris Dumez]

Created attachment 328206 [details]
WIP Patch

[Chris Dumez]

Created attachment 328252 [details]
WIP Patch

[Chris Dumez]

Created attachment 328261 [details]
Patch

[Darin Adler]

Comment on attachment 328261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328261&action=review

> Source/WebCore/ChangeLog:10
> +        thread safe by hoping to the right thread when necessary. In

hopping and hoping, not the same thing ;)

[Chris Dumez]

(In reply to Darin Adler from comment #4)
> Comment on attachment 328261 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328261&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        thread safe by hoping to the right thread when necessary. In
> 
> hopping and hoping, not the same thing ;)

lol, indeed :) Will fix before landing. Thanks for reviewing.

[Chris Dumez]

Created attachment 328273 [details]
Patch

[Chris Dumez]

Comment on attachment 328273 [details]
Patch

Clearing flags on attachment: 328273

Committed r225455: <https://trac.webkit.org/changeset/225455>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35816764>

[Simon Fraser (smfr)]

Comment on attachment 328273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328273&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:320
> +#ifndef NDEBUG
> +    ASSERT(m_creationThread == currentThread());
> +#endif

Why are these all wrapped in #ifndef NDEBUG ?

[Chris Dumez]

(In reply to Simon Fraser (smfr) from comment #10)
> Comment on attachment 328273 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=328273&action=review
> 
> > Source/WebCore/workers/service/ServiceWorkerContainer.cpp:320
> > +#ifndef NDEBUG
> > +    ASSERT(m_creationThread == currentThread());
> > +#endif
> 
> Why are these all wrapped in #ifndef NDEBUG ?

I don't see a good reason. This is a bit old but I have no idea why I did that. Anyway, I'll fix it shortly via Bug 224285.