It is currently in platform and used by platform/text for localization
Created attachment 328061 [details] Patch
Attachment 328061 [details] did not pass style-queue: ERROR: Source/WTF/wtf/DateComponents.h:88: The parameter name "format" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:123: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:125: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:127: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:129: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:131: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:134: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:137: The parameter name "months" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:181: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.h:182: The parameter name "ms" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/DateComponents.cpp:187: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WebCore/html/DateTimeInputType.h:42: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 12 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 328062 [details] Patch
Comment on attachment 328062 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=328062&action=review > Source/WTF/wtf/DateComponents.hSource/WebCore/platform/DateComponents.h:70 > + WTF_EXPORT_PRIVATE int millisecond() const { return m_millisecond; } Aren't these inlined? What is the EXPORT for?
(In reply to Myles C. Maxfield from comment #4) > Comment on attachment 328062 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=328062&action=review > > > Source/WTF/wtf/DateComponents.hSource/WebCore/platform/DateComponents.h:70 > > + WTF_EXPORT_PRIVATE int millisecond() const { return m_millisecond; } > > Aren't these inlined? What is the EXPORT for? I thought I remembered seeing linker errors with those inlined functions, but I tried it again and it looks like I was just overzealous with what I was exporting. I'll take those out. Thanks!
Created attachment 328143 [details] Patch for landing
Comment on attachment 328143 [details] Patch for landing Clearing flags on attachment: 328143 Committed r225430: <https://trac.webkit.org/changeset/225430>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35808884>
This caused and API failure on all Release Testers Example failure: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/1556 https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/1556/steps/run-api-tests/logs/stdio failure: FAIL WTF.StringOperators /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp:52 Value of: wtfStringCopyCount Actual: 0 Expected: 2 string + string /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp:54 Value of: wtfStringCopyCount Actual: 0 Expected: 2 atomicString + string
(In reply to Matt Lewis from comment #10) > This caused and API failure on all Release Testers This is a crazy linker issue caused by WTFString.h being included in different places making the same linker symbol in different translation units with different code being generated because WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING is defined to different things. I've fixed this before, but I don't remember how. It's quite tricky.
Reverted r225430 for reason: This caused an API failure on release. Committed r225555: <https://trac.webkit.org/changeset/225555>
(In reply to Alex Christensen from comment #11) > (In reply to Matt Lewis from comment #10) > > This caused and API failure on all Release Testers > This is a crazy linker issue caused by WTFString.h being included in > different places making the same linker symbol in different translation > units with different code being generated because > WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING is defined to different things. > I've fixed this before, but I don't remember how. It's quite tricky. Actually, it might be a different issue. Either way, quite tricky.