Bug 180210 – Clear WebSWClientConnection in case storage process IPC connection is closing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Clear WebSWClientConnection in case storage process IPC connection is closing

[youenn fablet]

Created attachment 328000 [details]
Patch

[youenn fablet]

Created attachment 328002 [details]
Patch

[Chris Dumez]

Comment on attachment 328000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328000&action=review

> Source/WebCore/ChangeLog:8
> +        No chnage of behavior.

typo: chnage.

Also, this does not seem to be true as it should fix flaky crashes on the bots.

> Source/WebCore/dom/Document.h:45
> +#include "SWClientConnection.h"

Do we really have to include this here? We should try and minimize new header includes on Document.h as much as possible because of build times.

> Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp:188
> +        callback({ });

What about all the pending ServiceWorkerJobs? Shouldn't we reject their promises and clear m_scheduledJobs?

[youenn fablet]

Created attachment 328022 [details]
Patch

[Chris Dumez]

Comment on attachment 328022 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 328022 [details]
Patch

Rejecting attachment 328022 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 328022, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 Skipping patch.
1 out of 1 hunk ignored
patching file Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp
patching file Source/WebKit/WebProcess/Storage/WebSWClientConnection.h
patching file Source/WebKit/WebProcess/Storage/WebToStorageProcessConnection.cpp
patching file Source/WebKit/WebProcess/Storage/WebToStorageProcessConnection.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5427171

[youenn fablet]

Created attachment 328101 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 328101 [details]
Patch for landing

Clearing flags on attachment: 328101

Committed r225399: <https://trac.webkit.org/changeset/225399>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35799710>