Bug 180208 - [JSC] Remove easy toRemove & map.remove() use in OAS phase
Summary: [JSC] Remove easy toRemove & map.remove() use in OAS phase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 180225
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-30 11:17 PST by Yusuke Suzuki
Modified: 2017-11-30 17:02 PST (History)
12 users (show)

See Also:


Attachments
Patch (10.80 KB, patch)
2017-11-30 11:19 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (7.92 KB, patch)
2017-11-30 16:22 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-11-30 11:17:04 PST
[JSC] Remove easy toRemove & map.remove() use
Comment 1 Yusuke Suzuki 2017-11-30 11:19:15 PST
Created attachment 327997 [details]
Patch
Comment 2 Mark Lam 2017-11-30 15:30:41 PST
Comment on attachment 327997 [details]
Patch

r=me
Comment 3 Yusuke Suzuki 2017-11-30 15:44:30 PST
Committed r225362: <https://trac.webkit.org/changeset/225362>
Comment 4 Radar WebKit Bug Importer 2017-11-30 15:45:34 PST
<rdar://problem/35784818>
Comment 5 WebKit Commit Bot 2017-11-30 16:11:59 PST
Re-opened since this is blocked by bug 180225
Comment 6 Yusuke Suzuki 2017-11-30 16:17:15 PST
It seems that DFGArgumentsEliminationPhase's change is bad one. But other ones are OK.
But basically this is optimization. I would like to keep applying this only to super simple and apparently correct ones. Like ones in DFGObjectAllocationSinkingPhase.cpp.
I think applying this to DFGObjectAllocationSinkingPhase.cpp is worth doing since basically DFGObjectAllocationSinkingPhase.cpp is known as super slow.

I'll only apply this change to DFGObjectAllocationSinkingPhase.cpp.
Comment 7 Yusuke Suzuki 2017-11-30 16:22:55 PST
Created attachment 328051 [details]
Patch
Comment 8 Mark Lam 2017-11-30 16:29:06 PST
Comment on attachment 328051 [details]
Patch

r=me
Comment 9 Yusuke Suzuki 2017-11-30 16:29:37 PST
Comment on attachment 328051 [details]
Patch

Thank you!
Comment 10 WebKit Commit Bot 2017-11-30 17:02:51 PST
Comment on attachment 328051 [details]
Patch

Clearing flags on attachment: 328051

Committed r225375: <https://trac.webkit.org/changeset/225375>
Comment 11 WebKit Commit Bot 2017-11-30 17:02:52 PST
All reviewed patches have been landed.  Closing bug.