RESOLVED FIXED 180208
[JSC] Remove easy toRemove & map.remove() use in OAS phase 
https://bugs.webkit.org/show_bug.cgi?id=180208
Summary [JSC] Remove easy toRemove & map.remove() use in OAS phase
Yusuke Suzuki
Reported 2017-11-30 11:17:04 PST
[JSC] Remove easy toRemove & map.remove() use
Attachments
Patch (10.80 KB, patch)
2017-11-30 11:19 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (7.92 KB, patch)
2017-11-30 16:22 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-11-30 11:19:15 PST
Created attachment 327997 [details] Patch
Mark Lam
Comment 2 2017-11-30 15:30:41 PST
Comment on attachment 327997 [details] Patch r=me
Yusuke Suzuki
Comment 3 2017-11-30 15:44:30 PST
Committed r225362: <https://trac.webkit.org/changeset/225362>
Radar WebKit Bug Importer
Comment 4 2017-11-30 15:45:34 PST
<rdar://problem/35784818>
WebKit Commit Bot
Comment 5 2017-11-30 16:11:59 PST
Re-opened since this is blocked by bug 180225
Yusuke Suzuki
Comment 6 2017-11-30 16:17:15 PST
It seems that DFGArgumentsEliminationPhase's change is bad one. But other ones are OK. But basically this is optimization. I would like to keep applying this only to super simple and apparently correct ones. Like ones in DFGObjectAllocationSinkingPhase.cpp. I think applying this to DFGObjectAllocationSinkingPhase.cpp is worth doing since basically DFGObjectAllocationSinkingPhase.cpp is known as super slow. I'll only apply this change to DFGObjectAllocationSinkingPhase.cpp.
Yusuke Suzuki
Comment 7 2017-11-30 16:22:55 PST
Created attachment 328051 [details] Patch
Mark Lam
Comment 8 2017-11-30 16:29:06 PST
Comment on attachment 328051 [details] Patch r=me
Yusuke Suzuki
Comment 9 2017-11-30 16:29:37 PST
Comment on attachment 328051 [details] Patch Thank you!
WebKit Commit Bot
Comment 10 2017-11-30 17:02:51 PST
Comment on attachment 328051 [details] Patch Clearing flags on attachment: 328051 Committed r225375: <https://trac.webkit.org/changeset/225375>
WebKit Commit Bot
Comment 11 2017-11-30 17:02:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.