Bug 180203 - Make WorkerThread lifetime much more predictable
Summary: Make WorkerThread lifetime much more predictable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 10:09 PST by Brady Eidson
Modified: 2017-11-30 13:03 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2017-11-30 10:48 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (3.40 KB, patch)
2017-11-30 11:36 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-11-30 10:09:41 PST 
Make WorkerThread lifetime much more predictable

Right now it's... not.
Comment 1 Brady Eidson 2017-11-30 10:48:04 PST 
Created attachment 327994 [details]
Patch
Comment 2 Chris Dumez 2017-11-30 10:59:51 PST 
Comment on attachment 327994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327994&action=review

r=me with a comment.

> Source/WebCore/workers/WorkerThread.cpp:237
> +    RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis)] { });

Should probably be a callOnMainThread() since we're in WebCore (and this code is likely used by iOS WK1)?
Comment 3 Brady Eidson 2017-11-30 11:36:10 PST 
Created attachment 327999 [details]
Patch
Comment 4 Brady Eidson 2017-11-30 11:36:25 PST 
Comment on attachment 327999 [details]
Patch

Will cq+ after EWS
Comment 5 WebKit Commit Bot 2017-11-30 13:01:16 PST 
Comment on attachment 327999 [details]
Patch

Clearing flags on attachment: 327999

Committed r225343: <https://trac.webkit.org/changeset/225343>
Comment 6 WebKit Commit Bot 2017-11-30 13:01:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-30 13:03:58 PST 
<rdar://problem/35780268>