Bug 180202 - [Mac] remove unneeded RetainPtr use introduced in r225142
Summary: [Mac] remove unneeded RetainPtr use introduced in r225142
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 09:58 PST by Darin Adler
Modified: 2017-11-30 15:33 PST (History)
3 users (show)

See Also:

Attachments
Patch (15.46 KB, patch)
2017-11-30 10:11 PST, Darin Adler 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2017-11-30 09:58:15 PST 
REGRESSION (r225142): [Cocoa] over-release of lookup options
Comment 1 Darin Adler 2017-11-30 10:11:22 PST 
Created attachment 327986 [details]
Patch
Comment 2 Darin Adler 2017-11-30 10:17:11 PST 
Committed r225331: <https://trac.webkit.org/changeset/225331>
Comment 3 Radar WebKit Bug Importer 2017-11-30 10:20:22 PST 
<rdar://problem/35775457>
Comment 4 Tim Horton 2017-11-30 10:33:15 PST 
Comment on attachment 327986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327986&action=review

> Source/WebCore/ChangeLog:9
> +        of RetainPtr because these use overrelease.

Heh, tiny phone review did not catch "overrelease" instead of "autorelease"
Comment 5 Darin Adler 2017-11-30 15:13:53 PST 
Comment on attachment 327986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327986&action=review

>> Source/WebCore/ChangeLog:9
>> +        of RetainPtr because these use overrelease.
> 
> Heh, tiny phone review did not catch "overrelease" instead of "autorelease"

But if you look at what I actually checked in, you’ll see I caught it in time!
Comment 6 Tim Horton 2017-11-30 15:33:09 PST 
Excellent :)