Bug 180191 - WebDriver: link and partial links queries don't work in xhtml documents
Summary: WebDriver: link and partial links queries don't work in xhtml documents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 05:39 PST by Carlos Garcia Campos
Modified: 2017-12-01 01:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2017-11-30 05:42 PST, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-30 05:39:18 PST 
We convert the queries to use xpath, which works for html documents, but it doesn't work for xhtml. In case of xhtml we would need to provide a namespace resolver and elements would need to be prefixed with xhtml: I would be a lot easier to simply iterate the link elements and copare the text.
Comment 1 Carlos Garcia Campos 2017-11-30 05:42:47 PST 
Created attachment 327971 [details]
Patch
Comment 2 BJ Burg 2017-11-30 15:53:29 PST 
Comment on attachment 327971 [details]
Patch

r=me

Oh well for trying to be clever!
Comment 3 Carlos Garcia Campos 2017-12-01 01:51:03 PST 
Committed r225388: <https://trac.webkit.org/changeset/225388>
Comment 4 Radar WebKit Bug Importer 2017-12-01 01:52:23 PST 
<rdar://problem/35793604>