Bug 180188 – Build fails on x86_64 and arm64 with BMalloc disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Tomas Popela]

In file included from /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource61.cpp:4:0:
/builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: In member function 'JSC::B3::Value* JSC::FTL::{anonymous}::LowerDFGToB3::caged(Gigacage::Kind, JSC::FTL::LValue)':
/builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:12325:24: error: 'isEnabled' is not a member of 'Gigacage'
         if (!Gigacage::isEnabled(kind))
                        ^~~~~~~~~

We are missing the isEnabled(Kind) method in Source/WTF/wtf/Gigacage.h.

[Tomas Popela]

And one more failure:

/builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:12335:66: error: invalid initialization of reference of type 'Gigacage::BasePtrs&' from expression of type 'Gigacage::Kind'
         LValue basePtr = m_out.constIntPtr(Gigacage::basePtr(kind));
                                                                  ^
In file included from /builddir/build/BUILD/webkitgtk-2.19.2/Source/WTF/wtf/CagedPtr.h:28:0,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/runtime/ArrayBuffer.h:31,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/heap/Heap.h:24,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/heap/DeferGC.h:29,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/runtime/ConcurrentJSLock.h:28,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/bytecode/ArrayProfile.h:28,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/bytecode/CodeBlock.h:32,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/jit/AssemblyHelpers.h:30,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/jit/CCallHelpers.h:30,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLazySlowPath.h:30,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLazySlowPath.cpp:27,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource61.cpp:1:
/builddir/build/BUILD/webkitgtk-2.19.2/Source/WTF/wtf/Gigacage.h:81:22: note: in passing argument 1 of 'void*& Gigacage::basePtr(Gigacage::BasePtrs&, Gigacage::Kind)'
 ALWAYS_INLINE void*& basePtr(BasePtrs& basePtrs, Kind kind)
                      ^~~~~~~

[Tomas Popela]

Created attachment 327966 [details]
Patch

[Tomas Popela]

Comment on attachment 327966 [details]
Patch

There is another failure while linking:

../../../lib/libjavascriptcoregtk-4.0.so.18.7.1: error: undefined reference to 'g_gigacageBasePtrs'

[Tomas Popela]

Created attachment 327976 [details]
Patch

[EWS Watchlist]

Attachment 327976 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Gigacage.cpp:35:  g_gigacageBasePtrs is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tomas Popela]

Comment on attachment 327976 [details]
Patch

Clearing flags on attachment: 327976

Committed r225471: <https://trac.webkit.org/changeset/225471>

[Tomas Popela]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35823524>

[Konstantin Tokarev]

Comment on attachment 327976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327976&action=review

> Source/WTF/wtf/Gigacage.cpp:35
> +char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE];

In Gigacage.h there is different definition

  extern "C" {
    extern WTF_EXPORTDATA char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE];
  }