Bug 180188 - Build fails on x86_64 and arm64 with BMalloc disabled
Summary: Build fails on x86_64 and arm64 with BMalloc disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tomas Popela
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-30 03:34 PST by Tomas Popela
Modified: 2017-12-06 02:58 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2017-11-30 03:57 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2017-11-30 07:35 PST, Tomas Popela 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2017-11-30 03:34:49 PST 
In file included from /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource61.cpp:4:0:
/builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: In member function 'JSC::B3::Value* JSC::FTL::{anonymous}::LowerDFGToB3::caged(Gigacage::Kind, JSC::FTL::LValue)':
/builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:12325:24: error: 'isEnabled' is not a member of 'Gigacage'
         if (!Gigacage::isEnabled(kind))
                        ^~~~~~~~~

We are missing the isEnabled(Kind) method in Source/WTF/wtf/Gigacage.h.
Comment 1 Tomas Popela 2017-11-30 03:45:50 PST 
And one more failure:

/builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:12335:66: error: invalid initialization of reference of type 'Gigacage::BasePtrs&' from expression of type 'Gigacage::Kind'
         LValue basePtr = m_out.constIntPtr(Gigacage::basePtr(kind));
                                                                  ^
In file included from /builddir/build/BUILD/webkitgtk-2.19.2/Source/WTF/wtf/CagedPtr.h:28:0,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/runtime/ArrayBuffer.h:31,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/heap/Heap.h:24,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/heap/DeferGC.h:29,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/runtime/ConcurrentJSLock.h:28,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/bytecode/ArrayProfile.h:28,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/bytecode/CodeBlock.h:32,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/jit/AssemblyHelpers.h:30,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/jit/CCallHelpers.h:30,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLazySlowPath.h:30,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/Source/JavaScriptCore/ftl/FTLLazySlowPath.cpp:27,
                 from /builddir/build/BUILD/webkitgtk-2.19.2/x86_64-redhat-linux-gnu/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource61.cpp:1:
/builddir/build/BUILD/webkitgtk-2.19.2/Source/WTF/wtf/Gigacage.h:81:22: note: in passing argument 1 of 'void*& Gigacage::basePtr(Gigacage::BasePtrs&, Gigacage::Kind)'
 ALWAYS_INLINE void*& basePtr(BasePtrs& basePtrs, Kind kind)
                      ^~~~~~~
Comment 2 Tomas Popela 2017-11-30 03:57:49 PST 
Created attachment 327966 [details]
Patch
Comment 3 Tomas Popela 2017-11-30 04:02:08 PST 
Comment on attachment 327966 [details]
Patch

There is another failure while linking:

../../../lib/libjavascriptcoregtk-4.0.so.18.7.1: error: undefined reference to 'g_gigacageBasePtrs'
Comment 4 Tomas Popela 2017-11-30 07:35:40 PST 
Created attachment 327976 [details]
Patch
Comment 5 EWS Watchlist 2017-11-30 07:38:19 PST 
Attachment 327976 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Gigacage.cpp:35:  g_gigacageBasePtrs is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Tomas Popela 2017-12-03 22:26:20 PST 
Comment on attachment 327976 [details]
Patch

Clearing flags on attachment: 327976

Committed r225471: <https://trac.webkit.org/changeset/225471>
Comment 7 Tomas Popela 2017-12-03 22:26:25 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-12-03 22:28:42 PST 
<rdar://problem/35823524>
Comment 9 Konstantin Tokarev 2017-12-06 02:58:44 PST 
Comment on attachment 327976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327976&action=review

> Source/WTF/wtf/Gigacage.cpp:35
> +char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE];

In Gigacage.h there is different definition

  extern "C" {
    extern WTF_EXPORTDATA char g_gigacageBasePtrs[GIGACAGE_BASE_PTRS_SIZE];
  }