Bug 180184 - [Attachment Support] Implement SPI for clients to update a given attachment's data
Summary: [Attachment Support] Implement SPI for clients to update a given attachment's...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-29 22:42 PST by Wenson Hsieh
Modified: 2017-12-16 13:23 PST (History)
5 users (show)

See Also:

Attachments
First pass (25.88 KB, patch)
2017-11-29 23:09 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (25.90 KB, patch)
2017-11-30 08:13 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (37.21 KB, patch)
2017-12-01 15:04 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-11-29 22:42:32 PST 
<rdar://problem/35355731>
Comment 1 Wenson Hsieh 2017-11-29 23:09:22 PST 
Created attachment 327955 [details]
First pass
Comment 2 Wenson Hsieh 2017-11-30 08:13:50 PST 
Created attachment 327978 [details]
Patch
Comment 3 Tim Horton 2017-12-01 14:02:43 PST 
Comment on attachment 327978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327978&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:275
> +        resultError = retainPtr(error);

Why even the retainPtr()?
Comment 4 Wenson Hsieh 2017-12-01 14:06:37 PST 
Comment on attachment 327978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327978&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:275
>> +        resultError = retainPtr(error);
> 
> Why even the retainPtr()?

True, explicit retainPtr()'s unneeded here. Removed!
Comment 5 Wenson Hsieh 2017-12-01 15:04:42 PST 
Created attachment 328165 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-12-01 15:36:45 PST 
Comment on attachment 328165 [details]
Patch for landing

Clearing flags on attachment: 328165

Committed r225422: <https://trac.webkit.org/changeset/225422>