Bug 180172 – Rename ImageFrameCache to ImageSource

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

This is a followup patch for https://bugs.webkit.org/show_bug.cgi?id=175595. ImageSource is the intended name after merging ImageFrameCache and ImageSource. After this patch the hierarchy will be the following:

CachedImage has a pointer to Image which can be a BitmapImage
BitmapImage has a pointer to ImageSource
ImageSource has a pointer to ImageDecoder and a Vector<ImageFrame>

[Said Abou-Hallawa]

Created attachment 327918 [details]
Patch

[EWS Watchlist]

Comment on attachment 327918 [details]
Patch

Attachment 327918 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5410946

New failing tests:
imported/w3c/web-platform-tests/resource-timing/single-entry-per-resource.html

[EWS Watchlist]

Created attachment 327934 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Said Abou-Hallawa]

Created attachment 327945 [details]
Patch

[Per Arne Vollan]

Comment on attachment 327945 [details]
Patch

Looks good! R=me.

[WebKit Commit Bot]

Comment on attachment 327945 [details]
Patch

Rejecting attachment 327945 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 327945, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ache.h
rm 'Source/WebCore/platform/graphics/ImageFrameCache.h'
patching file Source/WebCore/platform/graphics/ImageSource.cpp
patching file Source/WebCore/platform/graphics/ImageSource.h
patching file Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp
patching file Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Per Arne Vollan']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5448820

[Said Abou-Hallawa]

Created attachment 328162 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 328162 [details]
Patch

Clearing flags on attachment: 328162

Committed r225428: <https://trac.webkit.org/changeset/225428>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35808350>