Bug 180171 - Layout Test platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is flaky
Summary: Layout Test platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-29 15:43 PST by Ryan Haddad
Modified: 2018-06-15 09:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.30 KB, patch)
2018-04-09 12:43 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (5.36 KB, patch)
2018-04-09 15:20 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.82 KB, patch)
2018-06-15 08:52 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-11-29 15:43:39 PST
The following layout test is flaky on macOS, frequently timing out or failing. This is most apparent on High Sierra, but other versions are also affected.

platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=platform%2Fmac%2Fwebrtc%2FcaptureCanvas-webrtc-software-encoder.html

Diff from one of the failures on High Sierra:
--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/platform/mac/webrtc/captureCanvas-webrtc-software-encoder-actual.txt
@@ -1,4 +1,4 @@
    
 
-PASS captureStream with webrtc 
+FAIL captureStream with webrtc promise_test: Unhandled rejection with value: "test4 failed"
Comment 1 Ryan Haddad 2018-01-18 22:17:40 PST
Marked test as flaky on High Sierra in https://trac.webkit.org/changeset/227189/webkit
Comment 2 youenn fablet 2018-04-09 12:43:46 PDT
Created attachment 337527 [details]
Patch
Comment 3 youenn fablet 2018-04-09 15:20:06 PDT
Created attachment 337552 [details]
Patch
Comment 4 youenn fablet 2018-06-15 08:52:47 PDT
Created attachment 342816 [details]
Patch
Comment 5 WebKit Commit Bot 2018-06-15 09:19:27 PDT
Comment on attachment 342816 [details]
Patch

Clearing flags on attachment: 342816

Committed r232875: <https://trac.webkit.org/changeset/232875>
Comment 6 WebKit Commit Bot 2018-06-15 09:19:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-06-15 09:20:18 PDT
<rdar://problem/41161411>