Bug 180166 - When managing context startups, make ServiceWorkerJobDataIdentifier's optional
Summary: When managing context startups, make ServiceWorkerJobDataIdentifier's optional
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-29 14:05 PST by Brady Eidson
Modified: 2017-11-29 15:18 PST (History)
3 users (show)

See Also:

Attachments
Patch (20.89 KB, patch)
2017-11-29 14:08 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (20.83 KB, patch)
2017-11-29 14:44 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-11-29 14:05:30 PST 
When managing context startups, make ServiceWorkerJobDataIdentifier's optional
Comment 1 Brady Eidson 2017-11-29 14:06:08 PST 
Motivation: We'll sometimes be starting SW contexts without an associated job
Comment 2 Brady Eidson 2017-11-29 14:08:34 PST 
Created attachment 327902 [details]
Patch
Comment 3 Chris Dumez 2017-11-29 14:10:28 PST 
Comment on attachment 327902 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-11-29 14:20:01 PST 
Comment on attachment 327902 [details]
Patch

Rejecting attachment 327902 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 327902, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e/workers/service/server/SWServerWorker.h
patching file Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in
patching file Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
Hunk #2 succeeded at 174 (offset 3 lines).
patching file Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5408804
Comment 5 Chris Dumez 2017-11-29 14:44:02 PST 
Created attachment 327911 [details]
Patch
Comment 6 Chris Dumez 2017-11-29 14:44:26 PST 
Comment on attachment 327911 [details]
Patch

Conflicted with the patch I just landed so I rebaselined it.
Comment 7 WebKit Commit Bot 2017-11-29 15:16:08 PST 
Comment on attachment 327911 [details]
Patch

Clearing flags on attachment: 327911

Committed r225298: <https://trac.webkit.org/changeset/225298>
Comment 8 WebKit Commit Bot 2017-11-29 15:16:09 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-11-29 15:18:48 PST 
<rdar://problem/35758859>