Bug 180164 – Free FontFaceSets may include fonts that were never actually added to them

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Myles C. Maxfield]

We always add preinstalled fonts to CSSFontFaceSets, even if that CSSFontFaceSet was created by script and isn't owned by the Document. This is visible if you try to load one of these fonts.

[Myles C. Maxfield]

Created attachment 327892 [details]
Reproduction. Should alert("0")

[Myles C. Maxfield]

Looks like neither Firefox nor Chrome support constructing free FontFaceSets?

[Myles C. Maxfield]

at least, "new FontFaceSet([])" gives an error in those browsers.

[Myles C. Maxfield]

Created attachment 327950 [details]
WIP

[EWS Watchlist]

Attachment 327950 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

Created attachment 328011 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 328011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328011&action=review

> Source/WebCore/css/CSSFontFaceSet.cpp:169
> +            if (m_owningFontSelector)

Why the if check if it's always non-null?

> Source/WebCore/css/CSSFontFaceSet.h:110
> +    CSSFontSelector* m_owningFontSelector;

If this is always non-null why not use a ref?

[Myles C. Maxfield]

Comment on attachment 328011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328011&action=review

>> Source/WebCore/css/CSSFontFaceSet.h:110
>> +    CSSFontSelector* m_owningFontSelector;
> 
> If this is always non-null why not use a ref?

One client calls CSSFontFaceSet::create() with no arguments, and the (only) other client calls it with (this) as an argument.

[WebKit Commit Bot]

Comment on attachment 328011 [details]
Patch

Clearing flags on attachment: 328011

Committed r225414: <https://trac.webkit.org/changeset/225414>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35805626>