Bug 180149 - ensure*Connection() methods on WebProcess should return a reference
Summary: ensure*Connection() methods on WebProcess should return a reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-29 10:28 PST by Chris Dumez
Modified: 2017-12-02 12:40 PST (History)
6 users (show)

See Also:

Attachments
Patch (43.35 KB, patch)
2017-11-29 10:30 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-29 10:28:18 PST 
ensure*Connection() methods on WebProcess should return a reference instead of not returning anything. We can then get rid of the non-ensure variants (which called ensure internally).
Comment 1 Chris Dumez 2017-11-29 10:30:54 PST 
Created attachment 327869 [details]
Patch
Comment 2 WebKit Commit Bot 2017-11-29 11:40:16 PST 
Comment on attachment 327869 [details]
Patch

Clearing flags on attachment: 327869

Committed r225282: <https://trac.webkit.org/changeset/225282>
Comment 3 WebKit Commit Bot 2017-11-29 11:40:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-11-29 11:41:23 PST 
<rdar://problem/35753405>
Comment 5 Darin Adler 2017-12-02 12:40:46 PST 
I don’t think these functions need ensure in their names. Just makes the function names longer. It’s not like callers care about whether the things are created lazily or not.