Bug 180143 – ServiceWorkerClient objects should be reused if there is already one existing with the same identifier

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

ServiceWorkerClient objects should be reused if there is already one existing with the same identifier.

[youenn fablet]

Created attachment 327879 [details]
Patch

[Chris Dumez]

Comment on attachment 327879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327879&action=review

> Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h:97
> +    static bool isDeletedValue(const WebCore::ServiceWorkerClientIdentifier& slot) { return slot == WebCore::ServiceWorkerClientIdentifier { }; }

How does it differentiate empty from deleted values? It seems they are both { }, which seems wrong, no?

> Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:67
> +Ref<ServiceWorkerClient> ServiceWorkerGlobalScope::getOrCreateServiceWorkerClient(ServiceWorkerClientIdentifier identifier, ServiceWorkerClientData&& data)

For ServiceWorker / ServiceWorkerRegistration, we put the getOrCreate() method on the ServiceWorker / ServiceWorkerRegistration class. Could we follow the same pattern here for consistency?

[Chris Dumez]

(In reply to Chris Dumez from comment #2)
> Comment on attachment 327879 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327879&action=review
> 
> > Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h:97
> > +    static bool isDeletedValue(const WebCore::ServiceWorkerClientIdentifier& slot) { return slot == WebCore::ServiceWorkerClientIdentifier { }; }
> 
> How does it differentiate empty from deleted values? It seems they are both
> { }, which seems wrong, no?
> 
> > Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:67
> > +Ref<ServiceWorkerClient> ServiceWorkerGlobalScope::getOrCreateServiceWorkerClient(ServiceWorkerClientIdentifier identifier, ServiceWorkerClientData&& data)
> 
> For ServiceWorker / ServiceWorkerRegistration, we put the getOrCreate()
> method on the ServiceWorker / ServiceWorkerRegistration class. Could we
> follow the same pattern here for consistency?

And we should probably drop ServiceWorkerClient::create().

[youenn fablet]

Created attachment 327897 [details]
Patch

[youenn fablet]

(In reply to youenn fablet from comment #4)
> Created attachment 327897 [details]
> Patch

gtk failure is unrelated, patch updated according Chris comments.

[Chris Dumez]

Comment on attachment 327897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327897&action=review

r=me with comment.

> Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:67
> +ServiceWorkerClient* ServiceWorkerGlobalScope::getServiceWorkerClient(ServiceWorkerClientIdentifier identifier)

We normally avoid "get" prefix. I think this should be serviceWorkerClient(identifier).

[youenn fablet]

Created attachment 327923 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 327923 [details]
Patch for landing

Rejecting attachment 327923 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 327923, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Source/WebCore/workers/service/ServiceWorkerWindowClient.h
patching file Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
patching file LayoutTests/ChangeLog
patching file LayoutTests/http/tests/workers/service/resources/basic-ServiceWorker-postMessage-worker.js
patching file LayoutTests/http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5410834

[youenn fablet]

Created attachment 327926 [details]
Rebasing

[WebKit Commit Bot]

Comment on attachment 327926 [details]
Rebasing

Clearing flags on attachment: 327926

Committed r225308: <https://trac.webkit.org/changeset/225308>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35762146>