Bug 180131 - WebDriver: end point nodes are only allowed to have one session
Summary: WebDriver: end point nodes are only allowed to have one session
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 180133
  Show dependency tree / graph
 
Reported: 2017-11-29 01:14 PST by Carlos Garcia Campos
Modified: 2017-12-01 01:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (48.61 KB, patch)
2017-11-29 01:20 PST, Carlos Garcia Campos 		bburg: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.78 MB, application/zip)
2017-11-29 02:13 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-29 01:14:18 PST 
We are currently keeping a map of sessions, but our service is always and end point node, so only one session can exist at a time.

https://w3c.github.io/webdriver/webdriver-spec.html#dfn-maximum-active-sessions
Comment 1 Carlos Garcia Campos 2017-11-29 01:20:05 PST 
Created attachment 327844 [details]
Patch
Comment 2 EWS Watchlist 2017-11-29 01:22:33 PST 
Attachment 327844 [details] did not pass style-queue:


ERROR: Source/WebDriver/WebDriverService.h:119:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/WebDriverService.cpp:349:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2017-11-29 02:13:32 PST 
Comment on attachment 327844 [details]
Patch

Attachment 327844 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5400747

New failing tests:
webrtc/video-replace-muted-track.html
Comment 4 EWS Watchlist 2017-11-29 02:13:33 PST 
Created attachment 327846 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 BJ Burg 2017-11-30 16:16:40 PST 
Comment on attachment 327844 [details]
Patch

r=me. EWS thing is unrelated.
Comment 6 Carlos Garcia Campos 2017-12-01 01:47:26 PST 
Committed r225386: <https://trac.webkit.org/changeset/225386>
Comment 7 Radar WebKit Bug Importer 2017-12-01 01:48:30 PST 
<rdar://problem/35793565>