Bug 180125 - Web Inspector: Move console Preserve Log setting from Setting tab to Console navigation bar
Summary: Web Inspector: Move console Preserve Log setting from Setting tab to Console ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-28 20:42 PST by Joseph Pecoraro
Modified: 2017-11-28 21:09 PST (History)
5 users (show)

See Also:

Attachments
[IMAGE] Preserve Log - Console Navigation Item (47.10 KB, image/png)
2017-11-28 20:42 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (7.09 KB, patch)
2017-11-28 20:46 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-11-28 20:42:14 PST 
Move console Preserve Log setting from Setting tab to Console navigation bar

Just like we did for the Network tab.

Tooltip might need some love.
Comment 1 Joseph Pecoraro 2017-11-28 20:42:43 PST 
Created attachment 327824 [details]
[IMAGE] Preserve Log - Console Navigation Item
Comment 2 Joseph Pecoraro 2017-11-28 20:46:12 PST 
Created attachment 327825 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-11-28 20:46:33 PST 
Comment on attachment 327825 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327825&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:309
> +localizedStrings["Do not clear the console on new page loads"] = "Do not clear the console on new page loads";

I'm not totally happy with this tooltip but it seems fine.
Comment 4 Matt Baker 2017-11-28 20:53:39 PST 
Comment on attachment 327825 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327825&action=review

r=me

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:309
>> +localizedStrings["Do not clear the console on new page loads"] = "Do not clear the console on new page loads";
> 
> I'm not totally happy with this tooltip but it seems fine.

At least it matches the corresponding checkbox in the Network tab.
Comment 5 WebKit Commit Bot 2017-11-28 21:08:25 PST 
Comment on attachment 327825 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 327825

Committed r225257: <https://trac.webkit.org/changeset/225257>
Comment 6 WebKit Commit Bot 2017-11-28 21:08:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-28 21:09:27 PST 
<rdar://problem/35740623>