Bug 180125 – Web Inspector: Move console Preserve Log setting from Setting tab to Console navigation bar

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Move console Preserve Log setting from Setting tab to Console navigation bar

Just like we did for the Network tab.

Tooltip might need some love.

[Joseph Pecoraro]

Created attachment 327824 [details]
[IMAGE] Preserve Log - Console Navigation Item

[Joseph Pecoraro]

Created attachment 327825 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 327825 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327825&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:309
> +localizedStrings["Do not clear the console on new page loads"] = "Do not clear the console on new page loads";

I'm not totally happy with this tooltip but it seems fine.

[Matt Baker]

Comment on attachment 327825 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327825&action=review

r=me

>> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:309
>> +localizedStrings["Do not clear the console on new page loads"] = "Do not clear the console on new page loads";
> 
> I'm not totally happy with this tooltip but it seems fine.

At least it matches the corresponding checkbox in the Network tab.

[WebKit Commit Bot]

Comment on attachment 327825 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 327825

Committed r225257: <https://trac.webkit.org/changeset/225257>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35740623>