Bug 180124 - Web Inspector: Console Tab navigation bar sometimes does not include filter bar, clear console sometimes does not work
Summary: Web Inspector: Console Tab navigation bar sometimes does not include filter b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-28 20:15 PST by Joseph Pecoraro
Modified: 2017-11-29 11:07 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.50 KB, patch)
2017-11-28 20:19 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (4.43 KB, patch)
2017-11-28 20:37 PST, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-11-28 20:15:39 PST 
Console Tab navigation bar sometimes does not include filter bar

Steps to Reproduce:
1. Inspect this page
2. Show Debugger tab
3. Show Split Console drawer
4. Show Console tab
  => Console doesn't have filter bar, but it should

Notes:
- There are navigation items that only toggle when in the console tab, but those are sometimes not showing because "isShowingSplitConsole" is still true.
Comment 1 Joseph Pecoraro 2017-11-28 20:19:32 PST 
Created attachment 327822 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2017-11-28 20:24:16 PST 
Comment on attachment 327822 [details]
[PATCH] Proposed Fix

Nice fix, r=me
Comment 3 Joseph Pecoraro 2017-11-28 20:28:33 PST 
Comment on attachment 327822 [details]
[PATCH] Proposed Fix

There are actually a host of issues here. While this is correct I'm going to expand on it all in one patch.
Comment 4 Radar WebKit Bug Importer 2017-11-28 20:36:47 PST 
<rdar://problem/35740353>
Comment 5 Joseph Pecoraro 2017-11-28 20:37:38 PST 
Created attachment 327823 [details]
[PATCH] Proposed Fix
Comment 6 BJ Burg 2017-11-29 09:41:51 PST 
Comment on attachment 327823 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327823&action=review

r=me

> Source/WebInspectorUI/ChangeLog:21
> +        It is also now possible, to share a ContentView across ContentBrowsers via

Nit: -,
Comment 7 Joseph Pecoraro 2017-11-29 11:07:46 PST 
<https://trac.webkit.org/r225280>