Bug 180119 - Web Inspector: Cleanup Inspector classes be more consistent about using fast malloc / noncopyable
Summary: Web Inspector: Cleanup Inspector classes be more consistent about using fast ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-28 17:03 PST by Joseph Pecoraro
Modified: 2017-11-28 23:27 PST (History)
10 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (28.98 KB, patch)
2017-11-28 17:04 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-11-28 17:03:23 PST
Cleanup Inspector classes be more consistent about using fast malloc / noncopyable
Comment 1 Joseph Pecoraro 2017-11-28 17:04:41 PST
Created attachment 327806 [details]
[PATCH] Proposed Fix
Comment 2 EWS Watchlist 2017-11-28 17:06:52 PST
Attachment 327806 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:25:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Devin Rousso 2017-11-28 22:22:33 PST
Comment on attachment 327806 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=327806&action=review

r=me.  Nice!

> Source/WebCore/ChangeLog:25
> +        * inspector/agents/*

Style checker thinks you're missing a semicolon.  I'm not sure what to do here 🤔
Comment 4 WebKit Commit Bot 2017-11-28 23:26:45 PST
Comment on attachment 327806 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 327806

Committed r225263: <https://trac.webkit.org/changeset/225263>
Comment 5 WebKit Commit Bot 2017-11-28 23:26:47 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-28 23:27:26 PST
<rdar://problem/35742431>