RESOLVED FIXED 180116
ServiceWorkerGlobalScope.clients should always return the same object 
https://bugs.webkit.org/show_bug.cgi?id=180116
Summary ServiceWorkerGlobalScope.clients should always return the same object
Chris Dumez
Reported 2017-11-28 15:29:02 PST
ServiceWorkerGlobalScope.clients should always return the same object, as per the specification: - https://w3c.github.io/ServiceWorker/#serviceworkerglobalscope-interface
Attachments
Patch (10.88 KB, patch)
2017-11-28 15:30 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.82 KB, patch)
2017-11-28 15:31 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.54 KB, patch)
2017-11-28 15:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (11.57 KB, patch)
2017-11-28 16:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-28 15:30:53 PST
Created attachment 327798 [details] Patch
Chris Dumez
Comment 2 2017-11-28 15:31:56 PST
Created attachment 327799 [details] Patch
Chris Dumez
Comment 3 2017-11-28 15:56:42 PST
Created attachment 327801 [details] Patch
Geoffrey Garen
Comment 4 2017-11-28 15:59:14 PST
rviceWorkerGlobalScope::visitAdditionalChildren(SlotVisitor& visitor) ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp: In function ‘void WebCore::visitAdditionalChildren(JSC::SlotVisitor&)’: ../../Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp:37:36: error: ‘wrapped’ was not declared in this scope visitor.addOpaqueRoot(&wrapped().clients());
Geoffrey Garen
Comment 5 2017-11-28 16:41:36 PST
C:\cygwin\home\buildbot\WebKit\Source\WebCore\bindings/js/JSServiceWorkerGlobalScopeCustom.cpp(35): error C2653: 'JSServiceWorkerGlobalScope': is not a class or namespace name (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource157.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebCore\bindings/js/JSServiceWorkerGlobalScopeCustom.cpp(37): error C3861: 'wrapped': identifier not found (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource157.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebCore\bindings/js/JSServiceWorkerGlobalScopeCustom.cpp(37): error C2228: left of '.clients' must have class/struct/union (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource157.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebCore\bindings/js/JSServiceWorkerGlobalScopeCustom.cpp(37): note: type is 'unknown-type' (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource157.cpp) C:\cygwin\home\buildbot\WebKit\Source\WebCore\bindings/js/JSServiceWorkerGlobalScopeCustom.cpp(38): error C3861: 'wrapped': identifier not found (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource157.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebCore\bindings/js/JSServiceWorkerGlobalScopeCustom.cpp(38): error C2228: left of '.registration' must have class/struct/union (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource157.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebCore\bindings/js/JSServiceWorkerGlobalScopeCustom.cpp(38): note: type is 'unknown-type' (compiling source file C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\DerivedSources\WebCore\unified-sources\UnifiedSource157.cpp)
Chris Dumez
Comment 6 2017-11-28 16:49:44 PST
Created attachment 327803 [details] Patch
Geoffrey Garen
Comment 7 2017-11-28 17:13:56 PST
Comment on attachment 327803 [details] Patch r=me
WebKit Commit Bot
Comment 8 2017-11-28 17:33:32 PST
Comment on attachment 327803 [details] Patch Clearing flags on attachment: 327803 Committed r225249: <https://trac.webkit.org/changeset/225249>
WebKit Commit Bot
Comment 9 2017-11-28 17:33:34 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-11-28 17:37:54 PST
<rdar://problem/35737919>
Note You need to log in before you can comment on or make changes to this bug.