Bug 180114 - Alternative Presentation Button: Provide a way to query for the replaced elements
Summary: Alternative Presentation Button: Provide a way to query for the replaced elem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-28 14:51 PST by Daniel Bates
Modified: 2017-12-01 16:09 PST (History)
5 users (show)

See Also:

Attachments
Patch and layout test (16.81 KB, patch)
2017-11-28 14:59 PST, Daniel Bates 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-11-28 14:51:36 PST 
Provide a way to query for the elements that were replaced by the Alternative Presentation Button.
Comment 1 Daniel Bates 2017-11-28 14:51:53 PST 
<rdar://problem/35710539>
Comment 2 Daniel Bates 2017-11-28 14:59:51 PST 
Created attachment 327796 [details]
Patch and layout test
Comment 3 Tim Horton 2017-12-01 16:02:38 PST 
Comment on attachment 327796 [details]
Patch and layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=327796&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:127
> +        [nodeHandles.get() addObject:wrapper(InjectedBundleNodeHandle::getOrCreate(element).get())];

No need for the first .get()
Comment 4 Daniel Bates 2017-12-01 16:09:12 PST 
Committed r225429: <https://trac.webkit.org/changeset/225429>