Add a toggle in the network tab to control automatically clearing or preserving log across loads We already have a checkbox in the Settings tab, but that is buried / hard to find. Include one in the Network tab.
<rdar://problem/34071789>
Created attachment 327789 [details] [IMAGE] Preserve Log - Checkbox Navigation Item
Created attachment 327790 [details] [PATCH] Proposed Fix
Comment on attachment 327790 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327790&action=review r=me, but the checkbox in the Settings tab should be removed. > Source/WebInspectorUI/ChangeLog:44 > + match existing generic places like TreeElement. Nice. > Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js:37 > + this.tooltip = toolTipOrLabel; Shouldn't this be `tooltipOrLabel`, to be consistent? I noticed that Wikipedia/the dictionary define it as a single word. In AppKit documentation it appears as one word, even though code samples use `toolTip` for some reason. > Source/WebInspectorUI/UserInterface/Views/CheckboxNavigationItem.js:33 > + this._checkboxElement.checked = checked; Oops. > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:102 > + this._checkboxsNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low; This makes me think we should add code to NavigationBar to automatically insert dividers between groups.
Comment on attachment 327790 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=327790&action=review >> Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.js:37 >> + this.tooltip = toolTipOrLabel; > > Shouldn't this be `tooltipOrLabel`, to be consistent? I noticed that Wikipedia/the dictionary define it as a single word. In AppKit documentation it appears as one word, even though code samples use `toolTip` for some reason. There are lot and lots of instances of "toolTip", I only changed the NavigationItem method ones. We can go through and change all the rest later. >> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:102 >> + this._checkboxsNavigationItemGroup.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low; > > This makes me think we should add code to NavigationBar to automatically insert dividers between groups. Yeah, I had thought about this. For now I'm fine with a little bit of manual work. Since groups don't handle visibility priority / hiding individual members right now, we will likely need to handle a lot of situations without groups to in order to get the hiding / collapsing behavior we want. The case I was thinking of was two adjacent checkboxes. If we had gone: Checkbox Checkbox Divider Button Divider Icon Then I'd have wanted to have grouped this: Checkbox (Checkbox Divider) (Button Divider) Icon This collapses gracefully as the bar gets smaller. Things hide left to right and the last item in a visual group hides its attached divider. In this case the two checkboxes are not grouped so individual items can be hidden. For comparison: (Checkbox Checkbox Divider) (Button Divider) Icon => Hides too much too soon since right now the entire group hides at once (Checkbox Divider) (Checkbox Divider) (Button Divider) Icon => I don't think the divider between checkboxes is the ideal presentation
Comment on attachment 327790 [details] [PATCH] Proposed Fix Clearing flags on attachment: 327790 Committed r225250: <https://trac.webkit.org/changeset/225250>
All reviewed patches have been landed. Closing bug.
> r=me, but the checkbox in the Settings tab should be removed. Oops, I didn't address this. I suppose we can remove it.