Bug 180107 - Clean up spanners before creating nested column context
Summary: Clean up spanners before creating nested column context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-28 13:47 PST by zalan
Modified: 2017-11-28 20:13 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.85 KB, patch)
2017-11-28 14:08 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-11-28 13:47:18 PST
rdar://problem/35686655
Comment 1 zalan 2017-11-28 14:08:18 PST
Created attachment 327785 [details]
Patch
Comment 2 Antti Koivisto 2017-11-28 16:55:01 PST
Comment on attachment 327785 [details]
Patch

Can we also delete some existing code dealing with spanner moving with this?
Comment 3 zalan 2017-11-28 19:53:08 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 327785 [details]
> Patch
> 
> Can we also delete some existing code dealing with spanner moving with this?

Unfortunately RenderTreeUpdater::MultiColumn::destroyFragmentedFlow still relies on that code for cleaning up nested multicols. I am fixing destroyFragmentedFlow now
Comment 4 WebKit Commit Bot 2017-11-28 20:12:36 PST
Comment on attachment 327785 [details]
Patch

Clearing flags on attachment: 327785

Committed r225255: <https://trac.webkit.org/changeset/225255>
Comment 5 WebKit Commit Bot 2017-11-28 20:12:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-28 20:13:20 PST
<rdar://problem/35740188>