Bug 180077 - Skip back and forward buttons should not hard-code their numeric amount in localised strings
Summary: Skip back and forward buttons should not hard-code their numeric amount in lo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-28 05:36 PST by Antoine Quint
Modified: 2017-11-28 07:01 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.84 KB, patch)
2017-11-28 05:53 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-11-28 05:36:11 PST 
We currently specify the skip back and skip forward buttons to use localised strings which hard-code the amount in them, for instance "Skip back 15 seconds". It would be preferable for localisation purposes to split the numeric amount in a separate localised string.
Comment 1 Antoine Quint 2017-11-28 05:36:22 PST 
<rdar://problem/34306985>
Comment 2 Antoine Quint 2017-11-28 05:53:56 PST 
Created attachment 327747 [details]
Patch
Comment 3 Eric Carlson 2017-11-28 06:17:02 PST 
Comment on attachment 327747 [details]
Patch

Nice test!
Comment 4 WebKit Commit Bot 2017-11-28 07:01:26 PST 
Comment on attachment 327747 [details]
Patch

Clearing flags on attachment: 327747

Committed r225216: <https://trac.webkit.org/changeset/225216>
Comment 5 WebKit Commit Bot 2017-11-28 07:01:27 PST 
All reviewed patches have been landed.  Closing bug.