WinCairoRequirements download prevents build scripts move forward. If it was downloaded, it had better to start building without checking the libraries are latest or not.
Created attachment 327837 [details] patch
Attachment 327837 [details] did not pass style-queue: ERROR: Tools/Scripts/download-latest-github-release.py:128: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 327838 [details] fix fix style
I want to work while I'm on the sky so that this patch was required.
Seems reasonable to me.
Comment on attachment 327838 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=327838&action=review LGTM on the logic, just some suggestions about naming improvements. > Tools/Scripts/download-latest-github-release.py:49 > + UP_TO_DATE_MAYBE = 3 Something like USING_EXISTING_VERSION would be clearer here. > Tools/Scripts/download-latest-github-release.py:85 > +def current_release(version_info_path): I think we should say "existing" instead. "current" sounds synonymous with "latest". > Tools/Scripts/download-latest-github-release.py:127 > + print 'Cannot download:', e Nit: You could probably align with the HTTPError case and do `print error.code, error.reason`, but this is fine too. > Tools/Scripts/download-latest-github-release.py:131 > + print 'Use current version:', version_info Nit: 'Using existing version:' would read better.
Created attachment 328031 [details] fix Thanks, Ross. I've changed them except error display. It doesn't have code property.
Created attachment 328032 [details] added reviewer Reviewed by Alex
Created attachment 328035 [details] added message output
Comment on attachment 328035 [details] added message output Clearing flags on attachment: 328035 Committed r225361: <https://trac.webkit.org/changeset/225361>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35784702>