Bug 180053 – Add Internals.terminateServiceWorker

• Status: RESOLVED
• Resolution: INVALID
• Component: WebCore Misc.

[Brady Eidson]

Add Internals.terminateServiceWorker

Useful for our own testing and importing other engine's tests

[Brady Eidson]

Created attachment 327671 [details]
Patch

[youenn fablet]

Sounds really cool!
There are some chromium specific tests that are using the same terminateServiceWorker test runner API.

We could try to import these.
See https://github.com/w3c/web-platform-tests/issues/6866 for discussion on uploading it to WPT.

[Brady Eidson]

(In reply to youenn fablet from comment #2)
> Sounds really cool!
> There are some chromium specific tests that are using the same
> terminateServiceWorker test runner API.
> 
> We could try to import these.
> See https://github.com/w3c/web-platform-tests/issues/6866 for discussion on
> uploading it to WPT.

Yup, that's why I am doing this! :)

[Brady Eidson]

Created attachment 327681 [details]
Patch

[EWS Watchlist]

Comment on attachment 327681 [details]
Patch

Attachment 327681 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5380415

New failing tests:
imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html

[EWS Watchlist]

Created attachment 327705 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Brady Eidson]

cache-match is a flake, this patch did not change things.

[WebKit Commit Bot]

Comment on attachment 327681 [details]
Patch

Rejecting attachment 327681 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 327681, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 at 86.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/workers/service/server/SWServer.h.rej
patching file Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.messages.in
patching file Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp
patching file Source/WebKit/WebProcess/Storage/WebSWClientConnection.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5381327

[Brady Eidson]

is it just me or has git/svn gotten stupider lately WRT resolving conflicts?

Forget it, I'll land this with changes that use it.