Created attachment 327659 [details] Crash Log The test imported/w3c/web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https.html is a flaky crash according to the dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fclaim-affect-other-registration.https.html https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r225170%20(1241)/results.html https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/builds/1241 stderr: ASSERTION FAILED: addResult.isNewEntry /Volumes/Data/slave/ios-simulator-11-debug/build/Source/WebCore/workers/service/server/SWServerRegistration.cpp(152) : void WebCore::SWServerRegistration::addClientUsingRegistration(const WebCore::ServiceWorkerClientIdentifier &) 1 0x10f73f57d WTFCrash 2 0x1148d78bd WebCore::SWServerRegistration::addClientUsingRegistration(WebCore::ServiceWorkerClientIdentifier const&) 3 0x1148d610c WebCore::SWServer::serviceWorkerStartedControllingClient(WebCore::SWServer::Connection&, WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long) 4 0x1148d604c WebCore::SWServer::Connection::serviceWorkerStartedControllingClient(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long) 5 0x1021cab44 void IPC::callMemberFunctionImpl<WebKit::WebSWServerConnection, void (WebCore::SWServer::Connection::*)(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long), std::__1::tuple<WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long>, 0ul, 1ul>(WebKit::WebSWServerConnection*, void (WebCore::SWServer::Connection::*)(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long), std::__1::tuple<WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) 6 0x1021ca8e0 void IPC::callMemberFunction<WebKit::WebSWServerConnection, void (WebCore::SWServer::Connection::*)(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long), std::__1::tuple<WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long>, std::__1::integer_sequence<unsigned long, 0ul, 1ul> >(std::__1::tuple<WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long>&&, WebKit::WebSWServerConnection*, void (WebCore::SWServer::Connection::*)(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long)) 7 0x1021c806f void IPC::handleMessage<Messages::WebSWServerConnection::ServiceWorkerStartedControllingClient, WebKit::WebSWServerConnection, void (WebCore::SWServer::Connection::*)(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long)>(IPC::Decoder&, WebKit::WebSWServerConnection*, void (WebCore::SWServer::Connection::*)(WTF::ObjectIdentifier<WebCore::ServiceWorkerIdentifierType>, unsigned long long)) 8 0x1021c75ac WebKit::WebSWServerConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 9 0x101b0cc16 WebKit::StorageToWebProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 10 0x1016a98a3 IPC::Connection::dispatchMessage(IPC::Decoder&) 11 0x10169f4f8 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 12 0x1016a9eaa IPC::Connection::dispatchOneMessage() 13 0x1016c1aed IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 14 0x1016c1a49 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() 15 0x10f7726db WTF::Function<void ()>::operator()() const 16 0x10f792c33 WTF::RunLoop::performWork() 17 0x10f7934b4 WTF::RunLoop::performWork(void*) 18 0x1057252b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 19 0x1057c4d31 __CFRunLoopDoSource0 20 0x105709c19 __CFRunLoopDoSources0 21 0x1057091ff __CFRunLoopRun 22 0x105708a89 CFRunLoopRunSpecific 23 0x100f75e5e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 24 0x100f75d39 -[NSRunLoop(NSRunLoop) run] 25 0x1072180d9 _xpc_objc_main 26 0x10721a4cb xpc_main 27 0x100ec9f3e main 28 0x106ec3d81 start 29 0x1 LEAK: 1 WebPageProxy LEAK: 1 WebPage LEAK: 2 WebFrame LEAK: 7 RenderObject LEAK: 118977 BidiRun LEAK: 1 Page LEAK: 2 Frame LEAK: 666 CachedResource LEAK: 187 WebCoreNode
Looking now.
Was able to reproduce like so: Tools/Scripts/run-webkit-tests --repeat-each=50 imported/w3c/web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https.html -f
I have a patch that works. Will upload shortly.
Created attachment 327683 [details] Patch
Comment on attachment 327683 [details] Patch Clearing flags on attachment: 327683 Committed r225198: <https://trac.webkit.org/changeset/225198>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35709212>