RESOLVED FIXED 180041
Give Document a strongly typed identifier instead of a uint64_t 
https://bugs.webkit.org/show_bug.cgi?id=180041
Summary Give Document a strongly typed identifier instead of a uint64_t
Chris Dumez
Reported 2017-11-27 09:47:27 PST
Give Document a strongly typed identifier instead of a uint64_t, for clarity.
Attachments
Patch (48.25 KB, patch)
2017-11-27 10:53 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-27 10:53:55 PST
Created attachment 327648 [details] Patch
youenn fablet
Comment 2 2017-11-27 10:59:10 PST
Comment on attachment 327648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327648&action=review > Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h:40 > + String toString() const { return String::number(serverConnectionIdentifier.toUInt64()) + "-" + String::number(contextIdentifier.toUInt64()); } Use StringBuilder? Also, is this toString() being used to generate client ids, thus potentially exposing to the web page server connection id and context id? If so, I am wondering whether we should not use some random UUID, at least when exposing the clientId to the web page, or have the storage process generate those random IDs.
Brady Eidson
Comment 3 2017-11-27 11:00:13 PST
Comment on attachment 327648 [details] Patch Fine once EWS is happy
Chris Dumez
Comment 4 2017-11-27 11:51:18 PST
Comment on attachment 327648 [details] Patch Clearing flags on attachment: 327648 Committed r225184: <https://trac.webkit.org/changeset/225184>
Chris Dumez
Comment 5 2017-11-27 11:51:20 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-11-27 11:52:19 PST
<rdar://problem/35703725>
Note You need to log in before you can comment on or make changes to this bug.