Bug 180033 – Pressing the space bar while watching a fullscreen video doesn't play or pause

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

Pressing the space bar while in fullscreen should toggle the media's playback state.

[Antoine Quint]

<rdar://problem/33610443>

[Antoine Quint]

Created attachment 327632 [details]
Patch

[EWS Watchlist]

Comment on attachment 327632 [details]
Patch

Attachment 327632 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5374406

New failing tests:
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html

[EWS Watchlist]

Created attachment 327633 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 327634 [details]
Patch

[Antoine Quint]

Committed r225173: <https://trac.webkit.org/changeset/225173>

[Matt Lewis]

This caused a consistent timeout on macOS Sierra and High Sierra for the tests:

media/fullscreen-api-enabled-media-with-presentation-mode.html
media/fullscreen-video-going-into-pip.html

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r225179%20(4178)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/4178

[Matt Lewis]

Reverted r225173 for reason:

This caused multiple tests to timeout consistently.

Committed r225200: <https://trac.webkit.org/changeset/225200>

[WebKit Commit Bot]

Comment on attachment 327634 [details]
Patch

Clearing flags on attachment: 327634

Committed r225201: <https://trac.webkit.org/changeset/225201>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

It looks like the commit queue decided it really didn't want to let this patch go. Reverting again.

[Matt Lewis]

Reverted r225201 for reason:

This caused multiple tests to timeout consistently.

Committed r225204: <https://trac.webkit.org/changeset/225204>

[Antoine Quint]

Committed r225209: <https://trac.webkit.org/changeset/225209>

[Ryan Haddad]

(In reply to Antoine Quint from comment #13)
> Committed r225209: <https://trac.webkit.org/changeset/225209>
The two fullscreen tests that started timing out with the original commit are still timing out with this change:

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/5977

[WebKit Commit Bot]

Re-opened since this is blocked by bug 180092

[Alexey Proskuryakov]

Rolled back in r225222: <https://trac.webkit.org/changeset/225222>

[Alexey Proskuryakov]

Comment on attachment 327634 [details]
Patch

MArking r- as this breaks tests. Please don't re-land until you fix the problem, skipping them is not OK.

[Antoine Quint]

The tests that timed out were generating a keydown event with the key set to the space bar, which would cause media playback to be toggled when changing presentation mode. The fix is to change the key used in this scenario since it can be mostly any key.

[Antoine Quint]

Committed r225265: <https://trac.webkit.org/changeset/225265>