Bug 180032 - [WPE][GTK] Improve contents of pkg-config .pc files
Summary: [WPE][GTK] Improve contents of pkg-config .pc files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-27 05:50 PST by Adrian Perez
Modified: 2017-11-27 06:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2017-11-27 05:54 PST, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-11-27 05:50:47 PST 
The .pc files for the WPE and GTK+ ports could use some love:

 - Missing “URL” fields.
 - The “Name” field could be nicer, e.g. it reads just “WebKit2” for
   the GTK+ port, when it probably should be “WebKitGTK+”.
Comment 1 Adrian Perez 2017-11-27 05:54:09 PST 
Created attachment 327631 [details]
Patch
Comment 2 Adrian Perez 2017-11-27 05:56:17 PST 
(In reply to Adrian Perez from comment #0)
> The .pc files for the WPE and GTK+ ports could use some love:
> 
>  - Missing “URL” fields.
>  - The “Name” field could be nicer, e.g. it reads just “WebKit2” for
>    the GTK+ port, when it probably should be “WebKitGTK+”.

Also, both WPE and GTK+ ports had the value “WebKit2” in their “Name”
fields. It seems better to have different names ;-)
Comment 3 WebKit Commit Bot 2017-11-27 06:16:56 PST 
Comment on attachment 327631 [details]
Patch

Clearing flags on attachment: 327631

Committed r225167: <https://trac.webkit.org/changeset/225167>
Comment 4 WebKit Commit Bot 2017-11-27 06:16:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-27 06:17:25 PST 
<rdar://problem/35696892>