Bug 180031 - REGRESSION(r223073): disk cache directory is no longer copied in ProcessPoolConfiguration::copy()
Summary: REGRESSION(r223073): disk cache directory is no longer copied in ProcessPoolC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2017-11-27 05:16 PST by Carlos Garcia Campos
Modified: 2017-11-27 08:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2017-11-27 05:19 PST, Carlos Garcia Campos 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-27 05:16:58 PST 
This has caused GTK/WPE test /webkit2/WebKitWebsiteData/configuration to fail, and the wrong directory is used by the network process. I think it was removed by mistake in r223073.

TEST: ./Tools/glib/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestWebsiteData... (pid=5917)

  /webkit2/WebKitWebsiteData/configuration:
**

ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:168:void testWebsiteDataConfiguration(WebsiteDataTest*, gconstpointer): assertion failed: (g_file_test(diskCacheDirectory.get(), G_FILE_TEST_IS_DIR))

FAIL
Comment 1 Carlos Garcia Campos 2017-11-27 05:19:10 PST 
Created attachment 327630 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-11-27 08:31:07 PST 
Committed r225171: <https://trac.webkit.org/changeset/225171>
Comment 3 Radar WebKit Bug Importer 2017-11-27 08:32:18 PST 
<rdar://problem/35698329>