Bug 180022 - [FTL] Support DeleteById and DeleteByVal
Summary: [FTL] Support DeleteById and DeleteByVal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-26 17:08 PST by Yusuke Suzuki
Modified: 2017-11-26 19:48 PST (History)
10 users (show)

See Also:


Attachments
Patch (5.72 KB, patch)
2017-11-26 17:10 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2017-11-26 17:11 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-11-26 17:08:02 PST
[FTL] Support DeleteById and DeleteByVal
Comment 1 Yusuke Suzuki 2017-11-26 17:10:09 PST
Created attachment 327595 [details]
Patch
Comment 2 Yusuke Suzuki 2017-11-26 17:11:32 PST
Created attachment 327596 [details]
Patch
Comment 3 Saam Barati 2017-11-26 17:21:30 PST
Comment on attachment 327596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327596&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        We should increase the coverage of FTL. Even if the code includes DeleteById,
> +        it does not mean that remaining part of the code should not be optimized in FTL.
> +        Right now, even CallEval and `with` scope are handled in FTL.
> +

Nice. I remember doing this a while ago too locally! I forgot to land it :(
Comment 4 Yusuke Suzuki 2017-11-26 17:25:46 PST
Comment on attachment 327596 [details]
Patch

Thanks :D
Comment 5 WebKit Commit Bot 2017-11-26 19:46:01 PST
Comment on attachment 327596 [details]
Patch

Clearing flags on attachment: 327596

Committed r225153: <https://trac.webkit.org/changeset/225153>
Comment 6 WebKit Commit Bot 2017-11-26 19:46:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-26 19:48:28 PST
<rdar://problem/35691734>